Skip to content

[lunarg-vulkantools] Switch to Qt6 [qtwebengine] Resolve protobuf include quirk#46058

Merged
JavierMatosD merged 7 commits into
microsoft:masterfrom
dg0yt:vulkan-tools
Oct 8, 2025
Merged

[lunarg-vulkantools] Switch to Qt6 [qtwebengine] Resolve protobuf include quirk#46058
JavierMatosD merged 7 commits into
microsoft:masterfrom
dg0yt:vulkan-tools

Conversation

@dg0yt
Copy link
Copy Markdown
Contributor

@dg0yt dg0yt commented Jun 18, 2025 •
edited
Loading

Qt5 is EOL.

Switching to Qt6 changed installation order for qtwebengine vs. protobuf, exposing a conflict between protobuf in vcpkg and the vendored protobuf in qtwebengine. (qtwebengine doesn't accept system protobuf.)

dg0yt
dg0yt commented Jun 18, 2025
View reviewed changes
Comment thread ports/lunarg-vulkantools/portfile.cmake
HEAD_REF main
PATCHES
disable-qtdeploy.patch
jsoncpp.diff
Copy link
Copy Markdown
Contributor Author

@dg0yt dg0yt Jun 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LunarG/VulkanTools#2430

@Cheney-W Cheney-W self-assigned this Jun 18, 2025
@Cheney-W Cheney-W added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist category:code-cleanup labels Jun 18, 2025
@dg0yt
Copy link
Copy Markdown
Contributor Author

dg0yt commented Jun 21, 2025

IIUC qtwebengine fails because QtGUI pulls in the top-level include dir with port protobuf's headers before webengine's chromium's vendored protobuf headers.

@dg0yt
Copy link
Copy Markdown
Contributor Author

dg0yt commented Jun 22, 2025

Of cource I must first fix qtbase before I can study and fix qtwebengine. And then there is qtdeclarative which fails to build the x64-linux debug variant with 100 GB of virtual memory.

@dg0yt dg0yt marked this pull request as draft June 22, 2025 08:09
@dg0yt
Copy link
Copy Markdown
Contributor Author

dg0yt commented Jun 22, 2025

qtwebengine sucks.

[21252/41594] CXX host/obj/third_party/perfetto/src/trace_processor/db/db/column.o
ninja: build stopped: subcommand failed.
...
Elapsed time to handle qtwebengine:x64-linux-dynamic: 1.7 h

@dg0yt
Copy link
Copy Markdown
Contributor Author

dg0yt commented Jun 24, 2025 •
edited
Loading

qtwebengine issue not reproduced in x64-linux-dynamic release-only, after 7.4 h of building. That single port.

@dg0yt dg0yt mentioned this pull request Jun 25, 2025
Merged
@dg0yt
Copy link
Copy Markdown
Contributor Author

dg0yt commented Jul 11, 2025

Depends on #46162.

@dg0yt dg0yt marked this pull request as ready for review July 16, 2025 07:12
@dg0yt dg0yt marked this pull request as draft July 16, 2025 20:55
@dg0yt
Copy link
Copy Markdown
Contributor Author

dg0yt commented Jul 16, 2025

Still dying in vendored protobuf vs. vcpkg include dirs.

@dg0yt dg0yt mentioned this pull request Jul 30, 2025
Closed
7 tasks
@dg0yt dg0yt mentioned this pull request Sep 13, 2025
Closed
@dg0yt dg0yt changed the title [lunarg-vulkantools] Switch to Qt6 [lunarg-vulkantools] Switch to Qt6 [qtwebengine] Resolve protobuf include quirk Oct 6, 2025
@dg0yt dg0yt closed this Oct 7, 2025
@dg0yt dg0yt reopened this Oct 7, 2025
@dg0yt dg0yt marked this pull request as ready for review October 7, 2025 05:58
@JavierMatosD
Copy link
Copy Markdown
Contributor

JavierMatosD commented Oct 8, 2025

Woah, this one has been open for a long time! Thanks for your contributions @dg0yt!

@JavierMatosD JavierMatosD merged commit 8037a5d into microsoft:master Oct 8, 2025
19 checks passed
@dg0yt dg0yt deleted the vulkan-tools branch October 8, 2025 04:36
@dg0yt
Copy link
Copy Markdown
Contributor Author

dg0yt commented Oct 8, 2025

... yeah, and each qtwebengine build error only appeared after 33800 of 34000 steps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@JavierMatosD JavierMatosD JavierMatosD approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Cheney-W Cheney-W

Labels

category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dg0yt @JavierMatosD @BillyONeal @Cheney-W