Skip to content

vkvia: Maybe link to JsonCpp::JsonCpp#2430

Merged
christophe-lunarg merged 1 commit into
LunarG:vulkan-sdk-1.4.313from
dg0yt:patch-1
Jun 23, 2025
Merged

vkvia: Maybe link to JsonCpp::JsonCpp#2430
christophe-lunarg merged 1 commit into
LunarG:vulkan-sdk-1.4.313from
dg0yt:patch-1

Conversation

@dg0yt
Copy link
Copy Markdown

@dg0yt dg0yt commented Jun 18, 2025

In vcpkg, there is only one build type installed. JsonCpp::JsonCpp is always available from an installed jsoncpp.

@ci-tester-lunarg
Copy link
Copy Markdown

Author dg0yt not on autobuild list. Waiting for curator authorization before starting CI build.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Jun 18, 2025

CLA assistant check
All committers have signed the CLA.

@dg0yt dg0yt marked this pull request as ready for review June 18, 2025 07:58
@christophe-lunarg christophe-lunarg self-assigned this Jun 23, 2025
@christophe-lunarg christophe-lunarg added enhancement P2 Has a workaround / Minor feature OS - Windows Windows specific bug labels Jun 23, 2025
@christophe-lunarg
Copy link
Copy Markdown
Contributor

Thanks for contributing!

@christophe-lunarg christophe-lunarg merged commit bff462e into LunarG:vulkan-sdk-1.4.313 Jun 23, 2025
1 check passed
@charles-lunarg
Copy link
Copy Markdown
Contributor

This appears to have been merged into the vulkan-sdk-1.4.313 branch, when it should have been merged into main. Typo?

@christophe-lunarg
Copy link
Copy Markdown
Contributor

This appears to have been merged into the vulkan-sdk-1.4.313 branch, when it should have been merged into main. Typo?

Not really, because vkvia was removed on main.

@charles-lunarg
Copy link
Copy Markdown
Contributor

Ah okay, that explains why it wasn't on main then! Just crossing my eye's and dotting my t's (intentional typo there :P )

@dg0yt dg0yt deleted the patch-1 branch June 23, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement OS - Windows Windows specific bug P2 Has a workaround / Minor feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants