[triplet] Xbox try-compile fix by using XBOX_CONSOLE_TARGET consistently#44172
Merged
BillyONeal merged 3 commits intomicrosoft:masterfrom Mar 5, 2025
Merged
[triplet] Xbox try-compile fix by using XBOX_CONSOLE_TARGET consistently#44172BillyONeal merged 3 commits intomicrosoft:masterfrom
BillyONeal merged 3 commits intomicrosoft:masterfrom
Conversation
walbourn
changed the title
walbourn
changed the title
LilyWangLL
added
the
category:tool-update
LilyWangLL
approved these changes
Mar 5, 2025
LilyWangLL
added
the
info:needs-maintainer-attention
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The try-compile fix in [toolchain] Fixed a try_compile regression for xbox #44171 should be using
XBOX_CONSOLE_TARGETnotVCPKG_XBOX_CONSOLE_TARGET.Reverts the [triplet] xbox triplet fixes for handling Build Without Install #44122 changes to the triplets as not required. These three variables were already being captured by system.process.cpp.