[openNURBS] Update optimizer workaround condition from upstream

[WangWeiLin-MV]

Backport condition from upstream https://github.com/mcneel/opennurbs/blob/v8.12.24282.07001/opennurbs_lookup.cpp#L742-L743

And update workaround condition before _MSC_VER 1950

Related

• Solve an internal compiler issue on MSVC 2022 within openNURBS #5463
• Update opennurbs VS issue (opennurbs_lookup.cpp) #6143

[mvieth]

Hi, so the main difference is that with this PR, there is no upper MSVC version for which optimizations are not turned off any more. On the one hand this is reasonable because we do not actually know right now when the problem will be fixed in MSVC, but on the other hand we would have to remember to come back to this file and set the upper version in the future.
@larshg Thoughts?

[larshg]

I don't have any strong opinion - but I think I would just leave it as is. Then we at least get "reminders" whenever one update Visual Studio.

[WangWeiLin-MV]

What about plus 10, just like #5463

[WangWeiLin-MV]

Just ping.

[mvieth]

Sorry for the delay. In November, Visual Studio 2022 v17.12 was released, where presumably _MSC_VER=1942. I did not yet have the chance to test with that version, but I assume #pragma optimize("", off) is still needed. So yes, setting the upper bound to 1949 is a good idea. Thanks!
@larshg We should probably update at least one of our Azure Windows pipelines to Visual Studio 2022, currently they both use 2019.