Skip to content

[vcpkg] fix proxy hint that should be fixed long time ago#29346

Merged
JavierMatosD merged 2 commits intomicrosoft:masterfrom
reitowo:fix-proxy-hint
Feb 8, 2023
Merged

[vcpkg] fix proxy hint that should be fixed long time ago#29346
JavierMatosD merged 2 commits intomicrosoft:masterfrom
reitowo:fix-proxy-hint

Conversation

@reitowo
Copy link
Contributor

@reitowo reitowo commented Feb 1, 2023

As microsoft/vcpkg-tool#77 has been merged a long time ago, change the fail hint.

github-actions[bot]
github-actions bot previously approved these changes Feb 1, 2023
@FrankXie05 FrankXie05 added the category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly label Feb 1, 2023
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are editing this anyway it's probably a good idea to change this to discurage filing issues for transient upstream download server failures?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about:

If you've checked and believe this is not a "temporary" download server failure, please submit an issue at https://github.com/Microsoft/vcpkg/issues

@BillyONeal
Copy link
Member

BillyONeal commented Feb 1, 2023

I cancelled the build because the fleet is behind today, there were already failures on some platforms, and the build was messed up because our SAS tokens expired today, and there's an outstanding comment that would invalidate the work anyway.

I think the build failures are all going to be baseline issues because the asset cache SAS token expired.

@reitowo
Copy link
Contributor Author

reitowo commented Feb 2, 2023

Good, this kind of change always keep fleet behind for a long time, maybe we should do something to batch them in one PR?

@reitowo
Copy link
Contributor Author

reitowo commented Feb 7, 2023

@BillyONeal Hi Billy, can we merge this yet?

@reitowo
Copy link
Contributor Author

reitowo commented Feb 8, 2023

@FrankXie05 😘

@FrankXie05 FrankXie05 added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Feb 8, 2023
@JavierMatosD JavierMatosD merged commit 9d07914 into microsoft:master Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants