Skip to content

[vcpkg] fix proxy hint that should be fixed long time ago #29346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Javier Matos Denizac (JavierMatosD) merged 2 commits into from
Feb 8, 2023
Merged

[vcpkg] fix proxy hint that should be fixed long time ago #29346

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
de1adfc
fix proxy hint that should be fixed long time ago
reitowo Feb 1, 2023
3a5347a
rebase master
reitowo Feb 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 8 additions & 11 deletions scripts/cmake/vcpkg_download_distfile.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,27 +32,24 @@ function(z_vcpkg_download_distfile_show_proxy_and_fail error_code)
message(FATAL_ERROR
" \n"
" Failed to download file with error: ${error_code}\n"
" If you use a proxy, please check your proxy setting. Possible causes are:\n"
" If you are using a proxy, please check your proxy setting. Possible causes are:\n"
" \n"
" 1. You are actually using an HTTP proxy, but setting HTTPS_PROXY variable\n"
" to `https://address:port`. This is not correct, because `https://` prefix\n"
" claims the proxy is an HTTPS proxy, while your proxy (v2ray, shadowsocksr\n"
" , etc..) is an HTTP proxy. Try setting `http://address:port` to both\n"
" HTTP_PROXY and HTTPS_PROXY instead.\n"
" \n"
" 2. You are using Fiddler. Currently a bug (https://github.com/microsoft/vcpkg/issues/17752)\n"
" will set HTTPS_PROXY to `https://fiddler_address:port` which lead to problem 1 above.\n"
" Workaround is open Windows 10 Settings App, and search for Proxy Configuration page,\n"
" Change `http=address:port;https=address:port` to `address`, and fill the port number.\n"
" 2. If you are using Windows, vcpkg will automatically use your Windows IE Proxy Settings\n"
" set by your proxy software. See https://github.com/microsoft/vcpkg-tool/pull/77\n"
" The value set by your proxy might be wrong, or have same `https://` prefix issue.\n"
" \n"
" 3. Your proxy's remote server is out of service.\n"
" \n"
" In future vcpkg releases, if you are using Windows, you no longer need to set\n"
" HTTP(S)_PROXY environment variables. Vcpkg will simply apply Windows IE Proxy\n"
" Settings set by your proxy software. See (https://github.com/microsoft/vcpkg-tool/pull/49)\n"
" and (https://github.com/microsoft/vcpkg-tool/pull/77)\n"
" \n"
" Otherwise, please submit an issue at https://github.com/Microsoft/vcpkg/issues\n")
" If you've tried directly download the link, and believe this is not a temporary\n"
" download server failure, please submit an issue at https://github.com/Microsoft/vcpkg/issues\n"
" to report this upstream download server failure.\n"
" \n")
endfunction()

function(z_vcpkg_download_distfile_via_aria)
Expand Down