[gklib,metis,parmetis] Update sources for metis et al. to GitHub #26020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New port checklist: * Review the code :) * Check the name against https://repology.org/ There are 2 packages, both of which seem to be the same thing * Check the name against Bing/Google. It's the first entry. * Check the source code for optional `find_package`s There are none. * Check that the versioning scheme and license match what upstream says They have none. * Check that the source code comes from the upstream project's authoritative source. We did. * Check that the generated usage is accurate. * Check that the reported license is accurate. We hope so.
Resolves microsoft#25764 Competes with microsoft#25953
BillyONeal
added
category:port-bug
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
You have modified or added at least one vcpkg.json where you should check the license field.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/metis/vcpkg.jsonports/parmetis/vcpkg.json
Valid values for the license field can be found in the documentation
|
I solved.#25970 I changed the URL from "http://glaros.dtc.umn.edu/gkhome/fetch/sw/metis/metis-${METIS_VERSION}.tar.gz" to "https://www.nektar.info/thirdparty/metis-${METIS_VERSION}.tar.gz" Thank you! |
|
Great thanks @BillyONeal ! |
Closed
|
Any updates on this or on #25953? Our latest release depends on this. |
Sorry, I've been out on vacation since Thursday of last week; I'll see if I can fix the failures today but can't promise it will land today. |
BillyONeal
force-pushed
the
new-metis-sources
branch
from
288d4cf to
2af8aa9
Compare
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.
error: checked-in files for metis have changed but the version was not updated
version: 2022-07-27
old SHA: 9f22e9b4f191189fb70f72400da8aed05053e7b0
new SHA: 1a8b82dc534499155aca4057cb5ee998da7cdbc4
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
|
@ras0219 reviewed this over my shoulder |
BillyONeal
added a commit
to BillyONeal/vcpkg
that referenced
this pull request
Aug 4, 2022
In microsoft#26020 I forgot to apply @ras0219 's over the shoulder review comment to change the directory name to all lowercase.
clayne
pushed a commit
to clayne/vcpkg
that referenced
this pull request
Aug 4, 2022
* [gklib] Fix share path case. In microsoft#26020 I forgot to apply @ras0219 's over the shoulder review comment to change the directory name to all lowercase. * More case!
|
Thanks @BillyONeal ! |
p12tic
pushed a commit
to p12tic/vcpkg
that referenced
this pull request
Aug 25, 2022
…rosoft#26020) * Remove bogus arguments in the `vcpkg create` template. * [gklib] Add new port in support of metis and parmetis. New port checklist: * Review the code :) * Check the name against https://repology.org/ There are 2 packages, both of which seem to be the same thing * Check the name against Bing/Google. It's the first entry. * Check the source code for optional `find_package`s There are none. * Check that the versioning scheme and license match what upstream says They have none. * Check that the source code comes from the upstream project's authoritative source. We did. * Check that the generated usage is accurate. * Check that the reported license is accurate. We hope so. * [metis] Update source to github. Resolves microsoft#25764 Competes with microsoft#25953 * [parmetis] Update source to github. * Add licenses. * Fix GKlib case. * Fix metis install.
This was referenced Aug 25, 2022
ooeygui
pushed a commit
to ms-iot/vcpkg
that referenced
this pull request
Aug 25, 2022
…rosoft#26020) * Remove bogus arguments in the `vcpkg create` template. * [gklib] Add new port in support of metis and parmetis. New port checklist: * Review the code :) * Check the name against https://repology.org/ There are 2 packages, both of which seem to be the same thing * Check the name against Bing/Google. It's the first entry. * Check the source code for optional `find_package`s There are none. * Check that the versioning scheme and license match what upstream says They have none. * Check that the source code comes from the upstream project's authoritative source. We did. * Check that the generated usage is accurate. * Check that the reported license is accurate. We hope so. * [metis] Update source to github. Resolves microsoft#25764 Competes with microsoft#25953 * [parmetis] Update source to github. * Add licenses. * Fix GKlib case. * Fix metis install.
Closed
p12tic
pushed a commit
to p12tic/vcpkg
that referenced
this pull request
Sep 14, 2022
…rosoft#26020) * Remove bogus arguments in the `vcpkg create` template. * [gklib] Add new port in support of metis and parmetis. New port checklist: * Review the code :) * Check the name against https://repology.org/ There are 2 packages, both of which seem to be the same thing * Check the name against Bing/Google. It's the first entry. * Check the source code for optional `find_package`s There are none. * Check that the versioning scheme and license match what upstream says They have none. * Check that the source code comes from the upstream project's authoritative source. We did. * Check that the generated usage is accurate. * Check that the reported license is accurate. We hope so. * [metis] Update source to github. Resolves microsoft#25764 Competes with microsoft#25953 * [parmetis] Update source to github. * Add licenses. * Fix GKlib case. * Fix metis install.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates sources for metis and parmetis to GitHub. Also merges all patches together and makes things consistent in how CMake targets are exported.
Resolves #25764
Competes with #25953
Tested that parmetis works like this: