[gklib,metis,parmetis] Update sources for metis et al. to GitHub #26063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New port checklist: * Review the code :) * Check the name against https://repology.org/ There are 2 packages, both of which seem to be the same thing * Check the name against Bing/Google. It's the first entry. * Check the source code for optional `find_package`s There are none. * Check that the versioning scheme and license match what upstream says They have none. * Check that the source code comes from the upstream project's authoritative source. We did. * Check that the generated usage is accurate. * Check that the reported license is accurate. We hope so.
Resolves microsoft#25764 Competes with microsoft#25953
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.
error: checked-in files for metis have changed but the version was not updated
version: 2022-07-27
old SHA: 9f22e9b4f191189fb70f72400da8aed05053e7b0
new SHA: 55fc1949ed3d22c9c59ce5185ae3df5275296f03
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
error: checked-in files for gklib have changed but the version was not updated
version: 2022-07-27
old SHA: 444a1a611196fd37db09d8973bf6d32c4897ad65
new SHA: 1b796c472d5445312266ee5007a032445c75a2bf
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
|
Seems like Windows fails because of this line: https://github.com/KarypisLab/METIS/blob/94c03a6e2d1860128c2d0675cbbb86ad4f261256/CMakeLists.txt#L6 |
|
Upstream conventionally says GKlib, with GK capitalized and lib lowercased. (I had to fix several edge cases where I said GKLib 😅) |
JackBoosY
added
category:port-update
|
Closing because #26020 merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #26020