Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[gklib] Fix share path case. #26157

Merged
merged 2 commits into from
Aug 4, 2022
Merged

[gklib] Fix share path case. #26157

merged 2 commits into from
Aug 4, 2022

Conversation

BillyONeal
Copy link
Member

In #26020 I forgot to apply @ras0219 's over the shoulder review comment to change the directory name to all lowercase.

@BillyONeal
[gklib] Fix share path case.
b7fc5bc 
In microsoft#26020 I forgot to apply @ras0219 's over the shoulder review comment to change the directory name to all lowercase.
@BillyONeal BillyONeal added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Aug 4, 2022
github-actions[bot]
github-actions bot previously approved these changes Aug 4, 2022
View reviewed changes
@JackBoosY JackBoosY self-assigned this Aug 4, 2022
JackBoosY
JackBoosY previously approved these changes Aug 4, 2022
View reviewed changes
@JackBoosY JackBoosY added info:reviewed Pull Request changes follow basic guidelines and removed info:reviewed Pull Request changes follow basic guidelines labels Aug 4, 2022
@JackBoosY
Copy link
Contributor

JackBoosY commented Aug 4, 2022 •
edited
Loading 

-- Installing: /mnt/vcpkg-ci/packages/gklib_x64-linux/share/gklib/GKlibTargets.cmake
-- Installing: /mnt/vcpkg-ci/packages/gklib_x64-linux/share/gklib/GKlibTargets-release.cmake

Should also modify vcpkg_cmake_config_fixup(PACKAGE_NAME GKlib) to vcpkg_cmake_config_fixup(PACKAGE_NAME gklib) or just remove the parameter.

@dg0yt
Copy link
Contributor

dg0yt commented Aug 4, 2022

Should also modify vcpkg_cmake_config_fixup(PACKAGE_NAME GKlib) to vcpkg_cmake_config_fixup(PACKAGE_NAME gklib) or just remove the parameter.

PACKAGE_NAME is not needed at all here. The default is ${PORT}.

ras0219-msft
ras0219-msft previously approved these changes Aug 4, 2022
View reviewed changes
@dg0yt
Copy link
Contributor

dg0yt commented Aug 4, 2022

Note that the wrong package name breaks x64-linux. Windows doesn't fail because of its case-insensitive file system.

@BillyONeal BillyONeal merged commit 97f2693 into microsoft:master Aug 4, 2022
@BillyONeal BillyONeal deleted the gklib-case branch August 5, 2022 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

@JackBoosY JackBoosY JackBoosY left review comments

@ras0219-msft ras0219-msft ras0219-msft left review comments

Assignees

@JackBoosY JackBoosY

Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BillyONeal @JackBoosY @dg0yt @ras0219-msft