[liblas] use supports expression#25354
Closed
autoantwort wants to merge 1 commit intomicrosoft:masterfrom
Closed
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
dg0yt
reviewed
Jun 21, 2022
ports/liblas/vcpkg.json
Outdated
Contributor
There was a problem hiding this comment.
Are you sure? (macOS, iOS, Android?)
Contributor
Author
There was a problem hiding this comment.
[4/37] /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++ -DHAVE_LIBGEOTIFF=1 -DPROJ_DLL="" -Dlas_EXPORTS -I/Users/leanderSchulten/git_projekte/Lichtsteuerung/vcpkg/buildtrees/liblas/src/libLAS-1-c08fab38cc.clean/src/../include -isystem /Users/leanderSchulten/git_projekte/Lichtsteuerung/vcpkg_installed/arm64-osx/include -fPIC -Wextra -Wall -Wno-unused-parameter -Wno-unused-variable -Wpointer-arith -Wcast-align -Wcast-qual -Wfloat-equal -Wredundant-decls -Wno-long-long -g -arch arm64 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX12.3.sdk -fPIC -MD -MT src/CMakeFiles/las.dir/classification.cpp.o -MF src/CMakeFiles/las.dir/classification.cpp.o.d -o src/CMakeFiles/las.dir/classification.cpp.o -c /Users/leanderSchulten/git_projekte/Lichtsteuerung/vcpkg/buildtrees/liblas/src/libLAS-1-c08fab38cc.clean/src/classification.cpp
FAILED: src/CMakeFiles/las.dir/classification.cpp.o
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++ -DHAVE_LIBGEOTIFF=1 -DPROJ_DLL="" -Dlas_EXPORTS -I/Users/leanderSchulten/git_projekte/Lichtsteuerung/vcpkg/buildtrees/liblas/src/libLAS-1-c08fab38cc.clean/src/../include -isystem /Users/leanderSchulten/git_projekte/Lichtsteuerung/vcpkg_installed/arm64-osx/include -fPIC -Wextra -Wall -Wno-unused-parameter -Wno-unused-variable -Wpointer-arith -Wcast-align -Wcast-qual -Wfloat-equal -Wredundant-decls -Wno-long-long -g -arch arm64 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX12.3.sdk -fPIC -MD -MT src/CMakeFiles/las.dir/classification.cpp.o -MF src/CMakeFiles/las.dir/classification.cpp.o.d -o src/CMakeFiles/las.dir/classification.cpp.o -c /Users/leanderSchulten/git_projekte/Lichtsteuerung/vcpkg/buildtrees/liblas/src/libLAS-1-c08fab38cc.clean/src/classification.cpp
In file included from /Users/leanderSchulten/git_projekte/Lichtsteuerung/vcpkg/buildtrees/liblas/src/libLAS-1-c08fab38cc.clean/src/classification.cpp:43:
In file included from /Users/leanderSchulten/git_projekte/Lichtsteuerung/vcpkg/buildtrees/liblas/src/libLAS-1-c08fab38cc.clean/src/../include/liblas/detail/private_utility.hpp:46:
/Users/leanderSchulten/git_projekte/Lichtsteuerung/vcpkg/buildtrees/liblas/src/libLAS-1-c08fab38cc.clean/src/../include/liblas/detail/endian.hpp:96:3: error: The file liblas/detail/endian.hpp needs to be set up for your CPU type.
# error The file liblas/detail/endian.hpp needs to be set up for your CPU type.
^
1 error generated.
Member
There was a problem hiding this comment.
This seems to be patched but unreleased and the authors have deprecated the library since June 18, 2020.
I think this change to supports is fine, not asking to update library at this time.
Contributor
There was a problem hiding this comment.
@vicroms If you think this PR has nothing to modify at the moment, please remove the vcpkg-team-review label and add reviewed label.
Cheney-W
added
the
category:port-update
Contributor
|
@autoantwort Could you please add double quotes to all relative paths in portfile.cmake? |
autoantwort
force-pushed
the
liblas-supports
branch
from
aa79e55 to
419d5ec
Compare
Cheney-W
added
info:needs-maintainer-attention
dan-shaw
added
requires:vcpkg-team-review
Cheney-W
added
the
info:needs-maintainer-attention
dan-shaw
added
requires:vcpkg-team-review
Member
|
changes included in #25664 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.