Skip to content

liblas: disable#93631

Closed
iMichka wants to merge 1 commit intoHomebrew:masterfrom
iMichka:liblas
Closed

liblas: disable#93631
iMichka wants to merge 1 commit intoHomebrew:masterfrom
iMichka:liblas

Conversation

@iMichka
Copy link
Member

@iMichka iMichka commented Jan 22, 2022

This has been deprecated since 2018
No new release since then, and we were not able to bottle this for newest OS versions.

==> Analytics
install: 46 (30 days), 191 (90 days), 801 (365 days)
install-on-request: 45 (30 days), 189 (90 days), 794 (365 days)
build-error: 11 (30 days)

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@iMichka iMichka added the CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. label Jan 22, 2022
@BrewTestBot BrewTestBot added formula disabled Formula disabled no Linux bottle Formula has no Linux bottle labels Jan 22, 2022
This has been deprecated since 2018
No new release since then, and we were not able to bottle this for newest OS versions.

==> Analytics
install: 46 (30 days), 191 (90 days), 801 (365 days)
install-on-request: 45 (30 days), 189 (90 days), 794 (365 days)
build-error: 11 (30 days)
@carlocab
Copy link
Member

Does it fail to build on Catalina?

@BrewTestBot
Copy link
Contributor

@iMichka bottle request for liblas failed.

@iMichka
Copy link
Member Author

iMichka commented Jan 23, 2022

Failed on 10.15, see build above.

@carlocab
Copy link
Member

Looks like a user reported the issue upstream: libLAS/libLAS#213

Let's see how that turns out.

@Bo98
Copy link
Member

Bo98 commented Jan 25, 2022

Looks to me like it needs libLAS/libLAS@af431ab.

@iMichka
Copy link
Member Author

iMichka commented Jan 29, 2022

I tried to apply it but it then failed due to boost.
We asked for a tag 4 years ago: libLAS/libLAS#146
Upstream told 6 months ago that the tool was not actively maintained: libLAS/libLAS#205 (comment)

I am still in favour for disabling.

@Bo98
Copy link
Member

Bo98 commented Jan 29, 2022

Upstream told 6 months ago that the tool was not actively maintained: libLAS/libLAS#205 (comment)

Seems reasonable to me.

Actual deprecation date was 18 Jun 2020, which is a reasonable time period.

@iMichka iMichka added the ready to merge PR can be merged once CI is green label Jan 30, 2022
@iMichka iMichka requested review from Bo98 and carlocab January 30, 2022 16:00

deprecate! date: "2018-01-01", because: :unsupported
# Original deprecation date: 2018-01-01
disable! date: "2022-01-22", because: :unsupported
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
disable! date: "2022-01-22", because: :unsupported
disable! date: "2022-01-22", because: :unmaintained

Maybe

@BrewTestBot
Copy link
Contributor

🤖 A scheduled task has triggered a merge.

@iMichka iMichka deleted the liblas branch January 31, 2022 12:28
@github-actions github-actions bot added the outdated PR was locked due to age label Mar 3, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. formula disabled Formula disabled no Linux bottle Formula has no Linux bottle outdated PR was locked due to age ready to merge PR can be merged once CI is green

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants