[liblas] Fix geotiff dependency, document usage, add feature 'tools'#25664
Merged
vicroms merged 12 commits intomicrosoft:masterfrom Jul 11, 2022
Merged
[liblas] Fix geotiff dependency, document usage, add feature 'tools'#25664vicroms merged 12 commits intomicrosoft:masterfrom
vicroms merged 12 commits intomicrosoft:masterfrom
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
dg0yt
commented
Jul 10, 2022
ports/liblas/vcpkg.json
Outdated
Contributor
Author
There was a problem hiding this comment.
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.
error: checked-in files for liblas have changed but the version was not updated
version: 1.8.1#10
old SHA: 8981f7466bf5f1672d00d05407966ce7454b82ea
new SHA: a8a1998d6f4a81ca942d2fe2a9806b7292fe68da
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
JackBoosY
added
category:port-feature
JackBoosY
suggested changes
Jul 11, 2022
JackBoosY
reviewed
Jul 11, 2022
JackBoosY
approved these changes
Jul 11, 2022
Contributor
|
Then I will revert liblas part in my PR #25636 later. |
JackBoosY
added
the
info:needs-maintainer-attention
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative to #25636.
Includes #25354.
What does your PR fix?
Adds GeoTIFF package lookup to the exported config.
Adds a valid
usagefile.Adds a
toolsfeature for building utility programs.Cleanup and modernization.
liblas always builds shared libraries. This means
x64-windowsis actually unsupported. This PR doesn't change that. It just ensure that the DLLs are retained forx64-windows-static-md.Which triplets are supported/not supported? Have you updated the CI baseline?
unchanged, no
Does your PR follow the maintainer guide?
yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?yes