[wxwidgets] Remove debug asserts from Release build.#25240
Merged
dan-shaw merged 2 commits intomicrosoft:masterfrom Jun 16, 2022
Merged
[wxwidgets] Remove debug asserts from Release build.#25240dan-shaw merged 2 commits intomicrosoft:masterfrom
dan-shaw merged 2 commits intomicrosoft:masterfrom
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
AenBleidd
force-pushed
the
vko_fix_wxwidgets_release_build
branch
from
998987f to
78cf6cf
Compare
AenBleidd
force-pushed
the
vko_fix_wxwidgets_release_build
branch
from
78cf6cf to
b67b3ec
Compare
AenBleidd
force-pushed
the
vko_fix_wxwidgets_release_build
branch
from
b67b3ec to
d0177f8
Compare
Contributor
Author
|
Patch to wxCharts also pushed to mainstream: wxIshiko/wxCharts#201 |
LilyWangLL
added
the
category:port-bug
LilyWangLL
approved these changes
Jun 15, 2022
LilyWangLL
added
the
info:needs-maintainer-attention
Contributor
Author
|
wxIshiko/wxCharts#201 PR is merged on upstream. Looks like there is no 'releases' on that repo and current vcpkg port also refers to just some particular commit. |
Member
Yes, that would be great :) |
vicroms
added
requires:author-response
and removed
info:needs-maintainer-attention
Currently when building wxWidgets in Release mode, the debug asserts are enabled. This fixes this issue by providing a necessary define to disable them. Ref: https://docs.wxwidgets.org/3.1.6/group__group__funcmacro__debug.html [wxCharts, vcpkg-ci-wxwidgets] Update ports to include fix for wxWidgets release build with debug asserts off when building a dynamic/shared library. Signed-off-by: Vitalii Koshura <lestat.de.lionkur@gmail.com>
AenBleidd
force-pushed
the
vko_fix_wxwidgets_release_build
branch
from
d0177f8 to
2ccf65a
Compare
Contributor
Author
|
@vicroms, done. Please review |
LilyWangLL
added
the
info:needs-maintainer-attention
vicroms
pushed a commit
that referenced
this pull request
Jul 11, 2022
* Revert "[wxwidgets] Remove debug asserts from Release build. (#25240)" This reverts commit 6e16931. * Update to 3.1.7 * Update installation layout * Upstream CMake export is not ready for use * Update versions * Remove obsolete patch * Use msvc layout for mingw on windows * Add debug-support feature * Update versions * Fix condition * Update versions * Restore symlink patch * Update versions * Remove trace option from test port * Enable testing without feature debug-support * Fixup defaults for using without debug support * Expect wxrc-3.1 for mingw cross builds ("unix" layout) * Update versions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently when building wxWidgets in Release mode, the debug asserts are enabled.
This fixes this issue by providing a necessary define to disable them.
Ref: https://docs.wxwidgets.org/3.1.6/group__group__funcmacro__debug.html
Signed-off-by: Vitalii Koshura lestat.de.lionkur@gmail.com