Skip to content

Add possibility to remove debug asserts from the release build#201

Merged
xleclercq merged 1 commit intowxIshiko:mainfrom
AenBleidd:vko_fix_release_build
Jun 15, 2022
Merged

Add possibility to remove debug asserts from the release build#201
xleclercq merged 1 commit intowxIshiko:mainfrom
AenBleidd:vko_fix_release_build

Conversation

@AenBleidd
Copy link
Copy Markdown
Contributor

Signed-off-by: Vitalii Koshura lestat.de.lionkur@gmail.com

Signed-off-by: Vitalii Koshura <lestat.de.lionkur@gmail.com>
@xleclercq
Copy link
Copy Markdown
Member

I wasn't familiar with this wxDEBUG_LEVEL macro but looking at the documentation it impacts wxASSERT, wxFAIL and wxCHECK, which are not used in wxCharts (but probably should be at some point).
I guess I'm missing some info, can you explain what this fixes? Thanks.

@AenBleidd
Copy link
Copy Markdown
Contributor Author

@xleclercq, this PR fixes an issue when wxWidgets library is built with wxDEBUG_LEVEL=0 (that means no debug asserts) but when wxCharts using it without providing this flag (and by default in wx/debug.h this macro is not defined that enables debug asserts) that leads to linking issues similar to this (showing just the frrst one for example, the others are the same:

wxtimeserieschart.cpp.obj : error LNK2001: unresolved external symbol "__declspec(dllimport) void __cdecl wxOnAssert(char const *,int,char const *,char const *,char const *)" (__imp_?wxOnAssert@@YAXPEBDH000@Z)

@xleclercq
Copy link
Copy Markdown
Member

Thanks for explaining. Merged!

@AenBleidd AenBleidd deleted the vko_fix_release_build branch June 15, 2022 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants