[Windows] Add wxWidgets custom port with fixed release build#4787
Closed
AenBleidd wants to merge 1 commit intoBOINC:masterfrom
Closed
[Windows] Add wxWidgets custom port with fixed release build#4787AenBleidd wants to merge 1 commit intoBOINC:masterfrom
AenBleidd wants to merge 1 commit intoBOINC:masterfrom
Conversation
This fixes BOINC#4786. Signed-off-by: Vitalii Koshura <lestat.de.lionkur@gmail.com>
Contributor
|
vcpkg PR: |
talregev
approved these changes
Jun 16, 2022
Contributor
talregev
left a comment
talregev
left a comment
There was a problem hiding this comment.
vcpkg approve this change, it mean that it soon it will be in vcpkg master.
Also after talk with @AenBleidd, the change seems logical.
Also it compile and work on our CI.
I am prefer to wait vcpkg merge and not merge this PR to the maseter:
- Next batch vcpkg will merge this change.
- If this PR will merge, we will need to have a next PR that revert that changes.
- We usually waits for vcpkg PRs, unless is an hot fix for now.
Member
Author
|
Closed in favor of microsoft/vcpkg#25240 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #4786.
Signed-off-by: Vitalii Koshura lestat.de.lionkur@gmail.com