Suggest support expressions by autoantwort · Pull Request #21502 · microsoft/vcpkg

autoantwort · 2021-11-18T00:09:48Z

As an alternative to #21489

github-actions

You have modified or added at least one portfile where deprecated functions are used.

Details

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

ports/avisynthplus/portfile.cmake

If you feel able to do so, please remove `vcpkg_fail_port_install(...)` function calls and replace them with a equivalent [`supports` expressions](https://github.com/microsoft/vcpkg/blob/master/docs/users/manifests.md#supports) in the following `vcpkg.json` files: - `ports/avisynthplus/portfile.cmake`

github-actions

You have modified or added at least one portfile where deprecated functions are used.

Details

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

ports/avisynthplus/portfile.cmake

If you feel able to do so, please remove vcpkg_fail_port_install(...) function calls and replace them with a equivalent supports expressions in the following vcpkg.json files:

ports/avisynthplus/portfile.cmake

github-actions

You have modified or added at least one portfile where deprecated functions are used.

Details

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

ports/avisynthplus/portfile.cmake

If you feel able to do so, please remove vcpkg_fail_port_install(...) function calls and replace them with an equivalent supports expressions in the following vcpkg.json files:

ports/avisynthplus/portfile.cmake

github-actions

You have modified or added at least one portfile where deprecated functions are used.

Details

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

ports/avisynthplus/portfile.cmake

If you feel able to do so, please remove vcpkg_fail_port_install(...) function calls and replace them with an equivalent supports expression in the following vcpkg.json files:

ports/avisynthplus/portfile.cmake

autoantwort · 2022-01-05T12:13:35Z

Any news?

JackBoosY · 2022-01-06T17:03:45Z

Ping @strega-nil-ms for review this PR.

BillyONeal · 2022-01-21T18:20:03Z

This one is "easy" enough I think we should consider just bulk fixing them and truly deprecating...

autoantwort · 2022-01-21T21:00:51Z

There are "easy" cases, but there are also ports where there is an existing supports expression and a vcpkg_fail_port_install call, but they differ in semantics. So you have to fix all this ports manually. Currently vcpkg_fail_port_install is used in 293 ports.

BillyONeal · 2022-01-24T02:42:59Z

There are "easy" cases, but there are also ports where there is an existing supports expression and a vcpkg_fail_port_install call, but they differ in semantics. So you have to fix all this ports manually. Currently vcpkg_fail_port_install is used in 293 ports.

I'm down to 161 remaining and they've been relatively straightforward...

Supports expression simplified because uwp implies windows. In support of microsoft#21502

There was no supports expression before so there is ci.baseline.txt impact. In support of #21502

There was no supports expression so there was ci.baseline.txt impact. In support of #21502

There was no supports expression before so there was ci.baseline.txt impact. In support of #21502

There was no previous supports expression; I'm assuming given that the only block was for UWP that a dependency already did that. In support of #21502

This used plain ALWAYS which is identical to `message(FATAL_ERROR`. In support of #21502

vcpkg.json and portfile.cmake disagreed. ``` vcpkg.json: !osx & !uwp & (linux | !static) portfile.cmake: !osx & !uwp & (!windows | !(static | staticcrt)) ``` Trying to get portfile.cmake to agree: ``` !osx & !uwp & (!windows | !(static | staticcrt)) given !osx & !uwp & (!windows | (!static & !staticcrt)) demorgan ``` Considering !osx is earlier, I'm assuming Linux and !Windows are equivalent here: ``` !osx & !uwp & (linux | (!static & !staticcrt)) (above) ``` I'm assuming that portfile.cmake just never considered staticrt and linux, so I'm adding that condition. In support of #21502

Separated from the bulk PR because it adds to a feature. In support of #21502

The supports expression was missing a block for UWP that was in portfile.cmake. Also updates ci.baseline.txt. In support of #21502

There previously was no supports expression. In support of #21502

Separated out because it adds supports to a feature. In support of microsoft#21502

There was no previous supports and there was ci.baseline.txt impact. In support of microsoft#21502

There was no supports expression before, and there is ci.baseline.txt impact. In support of microsoft#21502

There was no supports expression before so this did have ci.baseline.txt impact. In support of #21502

BillyONeal · 2022-01-24T10:59:50Z

OK I have submitted PRs to eliminate all the calls; I would prefer to merge those then adopt #21489 (outright deprecation) instead.

* [zkpp] Remove vcpkg_fail_port_install. There was no supports expression before, and there is ci.baseline.txt impact. In support of #21502 * Fix flipped sense.

There was no previous supports and there was ci.baseline.txt impact. In support of #21502

Separated out because it adds supports to a feature. In support of #21502

Separated out because it adds a supports: to a feature. In support of #21502

There was no supports expression before so there was ci.baseline.txt impact. In support of microsoft#21502

BillyONeal · 2022-01-27T07:09:01Z

There are officially no more vcpkg_fail_port_install calls in master so I think we should do #21489 instead.

ras0219-msft · 2022-01-28T20:13:03Z

Agreed with @BillyONeal, closing this in favor of #21489. Thanks for the PR!

[docs] Improve documentation for support expressions

b0342f2