[chakracore] Remove vcpkg_fail_port_install.#22733
Merged
BillyONeal merged 1 commit intomicrosoft:masterfrom Jan 24, 2022
Merged
[chakracore] Remove vcpkg_fail_port_install.#22733BillyONeal merged 1 commit intomicrosoft:masterfrom
BillyONeal merged 1 commit intomicrosoft:masterfrom
Conversation
vcpkg.json and portfile.cmake disagreed. ``` vcpkg.json: !osx & !uwp & (linux | !static) portfile.cmake: !osx & !uwp & (!windows | !(static | staticcrt)) ``` Trying to get portfile.cmake to agree: ``` !osx & !uwp & (!windows | !(static | staticcrt)) given !osx & !uwp & (!windows | (!static & !staticcrt)) demorgan ``` Considering !osx is earlier, I'm assuming Linux and !Windows are equivalent here: ``` !osx & !uwp & (linux | (!static & !staticcrt)) (above) ``` I'm assuming that portfile.cmake just never considered staticrt and linux, so I'm adding that condition. In support of microsoft#21502
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/chakracore/vcpkg.json
Valid values for the license field are listed at https://spdx.org/licenses/
Contributor
There are bsd, android and ios triplets. |
Contributor
|
(There is also mingw. I wish there was |
Member
Author
Yes, but I don't think chakracore cared about those. |
Member
Author
|
(And of course folks trying to use such triplets were already presented with a rejection message.) |
JonLiu1993
added
the
category:port-bug
JonLiu1993
approved these changes
Jan 24, 2022
JonLiu1993
added
the
info:needs-maintainer-attention
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vcpkg.json and portfile.cmake disagreed.
Trying to get portfile.cmake to agree:
Considering !osx is earlier, I'm assuming Linux and !Windows are equivalent here:
I'm assuming that portfile.cmake just never considered staticrt and linux, so I'm adding that condition.
In support of #21502