Skip to content

[crashrpt] Remove vcpkg_fail_port_install.#22736

Merged
BillyONeal merged 1 commit intomicrosoft:masterfrom
BillyONeal:remove_fail_port_install_crashrpt
Jan 24, 2022
Merged

[crashrpt] Remove vcpkg_fail_port_install.#22736
BillyONeal merged 1 commit intomicrosoft:masterfrom
BillyONeal:remove_fail_port_install_crashrpt

Conversation

@BillyONeal
Copy link
Member

There previously was no supports expression.

In support of #21502

There previously was no supports expression.

In support of microsoft#21502
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one portfile where deprecated functions are used.

Details

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/crashrpt/portfile.cmake

You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/crashrpt/vcpkg.json

Valid values for the license field are listed at https://spdx.org/licenses/

@JonLiu1993 JonLiu1993 added the category:port-bug The issue is with a library, which is something the port should already support label Jan 24, 2022
@JonLiu1993 JonLiu1993 added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Jan 24, 2022
@BillyONeal BillyONeal merged commit 61ccae4 into microsoft:master Jan 24, 2022
@BillyONeal BillyONeal deleted the remove_fail_port_install_crashrpt branch January 24, 2022 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-bug The issue is with a library, which is something the port should already support info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants