Skip to content

[vcpkg baseline][tiff] Remove REQUIRED vcpkg-cmake-wrapper.in#18602

Closed
NancyLi1013 wants to merge 2 commits intomicrosoft:masterfrom
NancyLi1013:dev/NancyLi/fix-tiff
Closed

[vcpkg baseline][tiff] Remove REQUIRED vcpkg-cmake-wrapper.in#18602
NancyLi1013 wants to merge 2 commits intomicrosoft:masterfrom
NancyLi1013:dev/NancyLi/fix-tiff

Conversation

@NancyLi1013
Copy link
Contributor

Describe the pull request

  • What does your PR fix?

Currently simage failed with the following errors on x64-osx:

Even though we have disabled tiff via CMAKE_DISABLE_FIND_PACKAGE_TIFF on Windows and osx in simage, it will fail to build if installing tiff. Not sure why it still check tiff.

CMake Error at /Users/vagrant/Data/installed/x64-osx/share/jpeg/vcpkg-cmake-wrapper.cmake:1 (_find_package):
  _find_package for module JPEG called with REQUIRED, but
  CMAKE_DISABLE_FIND_PACKAGE_JPEG is enabled.  A REQUIRED package cannot be
  disabled.
Call Stack (most recent call first):
  /Users/vagrant/Data/work/1/s/scripts/buildsystems/vcpkg.cmake:718 (include)
  /Users/vagrant/Data/installed/x64-osx/share/tiff/vcpkg-cmake-wrapper.cmake:17 (find_package)
  /Users/vagrant/Data/work/1/s/scripts/buildsystems/vcpkg.cmake:718 (include)
  CMakeLists.txt:222 (find_package)

 

CMake Error at /Users/vagrant/Data/work/1/s/scripts/buildsystems/vcpkg.cmake:764 (_find_package):
  _find_package for module ZLIB called with REQUIRED, but
  CMAKE_DISABLE_FIND_PACKAGE_ZLIB is enabled.  A REQUIRED package cannot be
  disabled.
Call Stack (most recent call first):
  /Users/vagrant/Data/installed/x64-osx/share/tiff/vcpkg-cmake-wrapper.cmake:32 (find_package)
  /Users/vagrant/Data/work/1/s/scripts/buildsystems/vcpkg.cmake:718 (include)
  CMakeLists.txt:222 (find_package)

Related PR #18570

@NancyLi1013 NancyLi1013 added info:internal category:port-bug The issue is with a library, which is something the port should already support labels Jun 23, 2021
@dg0yt
Copy link
Contributor

dg0yt commented Jun 23, 2021

Tiff is the wrong port to patch. You must patch port simage. Either enable image format dependencies for uwp in vcpkg.json, or handle vcpkg target UWP like Windows and OSX in portfile.cmake. I don't know the desired behaviour.
Cf. #15683 (comment)
CC @ras0219-msft

@dg0yt
Copy link
Contributor

dg0yt commented Jun 23, 2021

Alternatively, there is #18473 for changing tiff's wrapper.

@JackBoosY JackBoosY added the requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. label Jun 24, 2021
@NancyLi1013
Copy link
Contributor Author

@ras0219 @ras0219-msft

Do you have any ideas about this problem?

@NancyLi1013
Copy link
Contributor Author

Closing this PR in flavor of #18645.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-bug The issue is with a library, which is something the port should already support requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants