[vcpkg baseline][tiff] Remove REQUIRED vcpkg-cmake-wrapper.in#18602
Closed
NancyLi1013 wants to merge 2 commits intomicrosoft:masterfrom
Closed
[vcpkg baseline][tiff] Remove REQUIRED vcpkg-cmake-wrapper.in#18602NancyLi1013 wants to merge 2 commits intomicrosoft:masterfrom
NancyLi1013 wants to merge 2 commits intomicrosoft:masterfrom
Conversation
Contributor
|
Tiff is the wrong port to patch. You must patch port simage. Either enable image format dependencies for uwp in |
Contributor
|
Alternatively, there is #18473 for changing tiff's wrapper. |
Contributor
Author
|
Do you have any ideas about this problem? |
Contributor
Author
|
Closing this PR in flavor of #18645. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the pull request
What does your PR fix?
Currently
simagefailed with the following errors on x64-osx:Even though we have disabled
tiffviaCMAKE_DISABLE_FIND_PACKAGE_TIFFon Windows and osx insimage, it will fail to build if installingtiff. Not sure why it still checktiff.Related PR #18570