Skip to content

[vcpkg_from_git] Support fetching from LFS-enabled repos#18570

Closed
ahojnnes wants to merge 1 commit intomicrosoft:masterfrom
ahojnnes:user/joschonb/git-lfs-support
Closed

[vcpkg_from_git] Support fetching from LFS-enabled repos#18570
ahojnnes wants to merge 1 commit intomicrosoft:masterfrom
ahojnnes:user/joschonb/git-lfs-support

Conversation

@ahojnnes
Copy link
Contributor

Patches the vcpkg_from_git function to configure the origin URL so that Git LFS smudge filters can successfully resolve file pointers.

@NancyLi1013 NancyLi1013 changed the title Support fetching from LFS-enabled repos [vcpkg_from_git] Support fetching from LFS-enabled repos Jun 22, 2021
@NancyLi1013 NancyLi1013 added the category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed label Jun 22, 2021
@NancyLi1013
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@NancyLi1013
Copy link
Contributor

NancyLi1013 commented Jun 23, 2021

simage failed on uwp:

4>D:\buildtrees\simage\src\mage-1.8.0-17f988a113.clean\src\simage_tiff.c(88,18): error C4996: 'uint16': libtiff type deprecated; please use corresponding C99 stdint.h type [D:\buildtrees\simage\x64-uwp-dbg\simage.vcxproj]
     4>D:\buildtrees\simage\src\mage-1.8.0-17f988a113.clean\src\simage_tiff.c(88,29): error C4996: 'uint16': libtiff type deprecated; please use corresponding C99 stdint.h type [D:\buildtrees\simage\x64-uwp-dbg\simage.vcxproj]
     4>D:\buildtrees\simage\src\mage-1.8.0-17f988a113.clean\src\simage_tiff.c(88,40): error C4996: 'uint16': libtiff type deprecated; please use corresponding C99 stdint.h type [D:\buildtrees\simage\x64-uwp-dbg\simage.vcxproj]

This has been solved via disabling in ci.baseline.txt in PR #18233.

paraview failed on linux:

Failed to download from mirror set:
https://vcpkgteststorage.blob.core.windows.net/osxpr20201017/6d2c1d6e1cd345547926938451755e7a8be5dabd89e18a2ceb419db16c5b29f354554a5130eb365b7e522d655370fd4766953813ff530c06e4851fe26104ce58?sv=2019-12-12&ss=b&srt=sco&sp=rwlac&se=2021-06-01T19:00:00Z&st=2021-02-02T21:14:48Z&spr=https&sig=5OqlHLAKxxH9%2F2G%2BwO4ngXiG%2Bd0ASB81PklNDOIAUUk%3D:   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (22) The requested URL returned error: 403 Server failed to authenticate the request. Make sure the value of Authorization header is formed correctly including the signature.

Seems like a network problem, will try to rerun this PR to solve this.

simage failed on x64-osx:

CMake Error at /Users/vagrant/Data/installed/x64-osx/share/jpeg/vcpkg-cmake-wrapper.cmake:1 (_find_package):
  _find_package for module JPEG called with REQUIRED, but
  CMAKE_DISABLE_FIND_PACKAGE_JPEG is enabled.  A REQUIRED package cannot be
  disabled.
Call Stack (most recent call first):
  /Users/vagrant/Data/work/1/s/scripts/buildsystems/vcpkg.cmake:718 (include)
  /Users/vagrant/Data/installed/x64-osx/share/tiff/vcpkg-cmake-wrapper.cmake:17 (find_package)
  /Users/vagrant/Data/work/1/s/scripts/buildsystems/vcpkg.cmake:718 (include)
  CMakeLists.txt:222 (find_package)


CMake Error at /Users/vagrant/Data/work/1/s/scripts/buildsystems/vcpkg.cmake:764 (_find_package):
  _find_package for module ZLIB called with REQUIRED, but
  CMAKE_DISABLE_FIND_PACKAGE_ZLIB is enabled.  A REQUIRED package cannot be
  disabled.
Call Stack (most recent call first):
  /Users/vagrant/Data/installed/x64-osx/share/tiff/vcpkg-cmake-wrapper.cmake:32 (find_package)
  /Users/vagrant/Data/work/1/s/scripts/buildsystems/vcpkg.cmake:718 (include)
  CMakeLists.txt:222 (find_package)

Confirmed, this is a bug, will be fixed by PR #18602.

librsvg failed on x64-windows:

CMake Error at CMakeLists.txt:79 (configure_file):
  No error

Seems like a parallel problem, will be fixed by PR #18600.

kf5completion failed on x86-window:

Installing in D:/packages/kf5completion_x86-windows/debug. Run D:/buildtrees/kf5completion/x86-windows-dbg/prefix.sh to set the environment for KCompletion.
-- Looking for __GLIBC__
-- Looking for __GLIBC__ - not found
CMake Error at D:/installed/x86-windows/share/ECM/kde-modules/KDEClangFormat.cmake:67 (configure_file):
  No such file or directory
Call Stack (most recent call first):
  D:/installed/x86-windows/share/ECM/kde-modules/KDEFrameworkCompilerSettings.cmake:79 (include)
  CMakeLists.txt:18 (include)

parallel problem, will be fixed by PR #18600.

opencv4 failed on x86-windows:

modules\videoio\CMakeFiles\opencv_videoio.dir/manifest.res" failed (exit code 0) with the following output:
Access violation[683/1352] cmd.exe /C "cd . && D:\downloads\tools\cmake-3.20.2-windows\cmake-3.20.2-windows-i386\bin\cmake.exe -E vs_link_dll --intdir=modules\wechat_qrcode\CMakeFiles\opencv_wechat_qrcode.dir --rc=C:\PROGRA~2\WI3CF2~1\10\bin\100190~1.0\x64\rc.exe --mt=C:\PROGRA~2\WI3CF2~1\10\bin\100190~1.0\x64\mt.exe --manifests  -- C:\PROGRA~2\MICROS~1\2019\ENTERP~1\VC\Tools\MSVC\1428~1.299\bin\Hostx64\x86\link.exe  

Cannot reproduce on local. Have no idea about this now.

@NancyLi1013
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JackBoosY JackBoosY requested a review from NancyLi1013 July 2, 2021 09:32
@NancyLi1013
Copy link
Contributor

Sorry for the long delay. Could you please resolve the conflicts @ahojnnes ?

@NancyLi1013
Copy link
Contributor

Hi @ahojnnes
Could you please merge master to solve the conflicts?

@PhoebeHui PhoebeHui assigned PhoebeHui and unassigned NancyLi1013 Nov 22, 2021
@PhoebeHui
Copy link
Contributor

Ping @ahojnnes for response, Is work still being done for this PR?

@ahojnnes
Copy link
Contributor Author

ahojnnes commented Dec 4, 2021

If I interpret the latest changes correctly, this issue has meanwhile been solved by somebody else.

@ahojnnes ahojnnes closed this Dec 4, 2021
@PhoebeHui
Copy link
Contributor

@ahojnnes, thanks for your response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants