Skip to content

[vcpkg baseline][gdal] Fix configure error on OSX#17083

Merged
vicroms merged 5 commits intomicrosoft:masterfrom
JackBoosY:dev/jack/16990
Apr 6, 2021
Merged

[vcpkg baseline][gdal] Fix configure error on OSX#17083
vicroms merged 5 commits intomicrosoft:masterfrom
JackBoosY:dev/jack/16990

Conversation

@JackBoosY
Copy link
Contributor

@JackBoosY JackBoosY commented Apr 4, 2021

Fixes #16990.

@JackBoosY JackBoosY added category:port-bug The issue is with a library, which is something the port should already support info:internal labels Apr 4, 2021
@JackBoosY
Copy link
Contributor Author

JackBoosY commented Apr 4, 2021

@cenit @Neumann-A do you have any suggestions about this?

Thanks.

Neumann-A
Neumann-A reviewed Apr 4, 2021
View reviewed changes
@Neumann-A
Copy link
Contributor

Neumann-A commented Apr 4, 2021 •
edited
Loading

https://lists.gnu.org/archive/html/bug-gettext/2011-10/msg00012.html.

Looking at the configure script it is only using AM_ICONV. Maybe touching the file is enough?

@vicroms
Copy link
Member

vicroms commented Apr 5, 2021

@Neumann-A

You mean like the original issue poster suggested?

execute_process(COMMAND touch ${SOURCE_PATH}/config.rpath)

@Neumann-A
Copy link
Contributor

Neumann-A commented Apr 5, 2021

@vicroms: Yes. But actually if we assume gettext[tools] is installed we can simply copy config.rpath from there. Seems like autopoint normally would install config.rpath but the gdal configure.ac file is not calling AM_GNU_GETTEXT([external]) before AM_ICONV

@JackBoosY
Copy link
Contributor Author

JackBoosY commented Apr 6, 2021

Works! Thanks @Neumann-A!

@PhoebeHui PhoebeHui mentioned this pull request Apr 6, 2021
Closed
@JackBoosY JackBoosY marked this pull request as ready for review April 6, 2021 03:52
@JackBoosY JackBoosY requested a review from PhoebeHui April 6, 2021 03:52
@JackBoosY
Copy link
Contributor Author

JackBoosY commented Apr 6, 2021

@strega-nil Ping for merge this PR quickly, this blocked many PRs.

PhoebeHui
PhoebeHui approved these changes Apr 6, 2021
View reviewed changes
Copy link
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we don't have a better solution for this now, it's fine to apply this workaroud for me.

@JackBoosY JackBoosY added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Apr 6, 2021
This was referenced Apr 6, 2021
Merged
Merged
Merged
@vicroms vicroms merged commit 88f0e6a into microsoft:master Apr 6, 2021
@JackBoosY JackBoosY deleted the dev/jack/16990 branch April 6, 2021 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PhoebeHui PhoebeHui PhoebeHui approved these changes

+1 more reviewer

@Neumann-A Neumann-A Neumann-A left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@PhoebeHui PhoebeHui

Labels

category:port-bug The issue is with a library, which is something the port should already support info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[gdal:x64-osx] configuration failure: required file 'config.rpath' not found

4 participants

@JackBoosY @Neumann-A @vicroms @PhoebeHui