Skip to content

vcpkg_configure_make: Add support for linux -> windows cross compilation#17073

Merged
strega-nil-ms merged 12 commits intomicrosoft:masterfrom
autoantwort:linux-windows-cross-compile
Apr 30, 2021
Merged

vcpkg_configure_make: Add support for linux -> windows cross compilation#17073
strega-nil-ms merged 12 commits intomicrosoft:masterfrom
autoantwort:linux-windows-cross-compile

Conversation

@autoantwort
Copy link
Contributor

Describe the pull request

This PR depends on #17068

@autoantwort autoantwort force-pushed the linux-windows-cross-compile branch from b77bce3 to db002b6 Compare April 4, 2021 00:53
@autoantwort autoantwort force-pushed the linux-windows-cross-compile branch from db002b6 to 9860e14 Compare April 4, 2021 09:16
@autoantwort
Copy link
Contributor Author

Failure because of #17009. Please rerun the pipeline :)

@JackBoosY JackBoosY self-assigned this Apr 5, 2021
@JackBoosY JackBoosY added the category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly label Apr 5, 2021
@autoantwort autoantwort force-pushed the linux-windows-cross-compile branch from 6440c6b to 9b571cf Compare April 5, 2021 15:40
@autoantwort
Copy link
Contributor Author

random pipeline failure because of #15324

@JackBoosY
Copy link
Contributor

Waiting for merge #17083.

@JackBoosY
Copy link
Contributor

Please get failure logs here.

@autoantwort
Copy link
Contributor Author

Please get failure logs here.

These failures are unrelated to this PR

@JackBoosY
Copy link
Contributor

Same error:

Can't exec "gtkdocize": No such file or directory at /usr/local/Cellar/autoconf/2.71/share/autoconf/Autom4te/FileUtils.pm line 293.
autoreconf: error: gtkdocize failed with exit status: 2

@autoantwort
Copy link
Contributor Author

autoantwort commented Apr 7, 2021

Same error:

Can't exec "gtkdocize": No such file or directory at /usr/local/Cellar/autoconf/2.71/share/autoconf/Autom4te/FileUtils.pm line 293.
autoreconf: error: gtkdocize failed with exit status: 2

Same error as in pipeline #17049, there a simple rerun fixed the issue (probably another osx build node was selected that don't has this issue)

I have not changes anything about the osx build in this PR

@Neumann-A
Copy link
Contributor

#13100 I added

# Required by libgpod
APT_PACKAGES="$APT_PACKAGES gtk-doc-tools"

for linux probably osx also needs this?

@autoantwort
Copy link
Contributor Author

APT_PACKAGES="$APT_PACKAGES gtk-doc-tools"

for linux probably osx also needs this?

brew install gtk-doc solved this issue. Thank you so much!

@autoantwort
Copy link
Contributor Author

@JackBoosY now the build was successful, you can review.

@autoantwort autoantwort force-pushed the linux-windows-cross-compile branch from 999a499 to 32dc769 Compare April 14, 2021 19:33
@JackBoosY
Copy link
Contributor

I will rerun the test later.

@autoantwort
Copy link
Contributor Author

I have no luck with hitting a osx pipeline machine where all necessary packages installed :(
Will have to wait for #17227

@autoantwort autoantwort requested a review from JackBoosY April 26, 2021 18:13
@JackBoosY
Copy link
Contributor

LGTM in my side, @Neumann-A do you have any questions?

@JackBoosY JackBoosY added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Apr 27, 2021
@strega-nil-ms
Copy link
Contributor

This looks good to me, thanks @autoantwort :)

@strega-nil-ms strega-nil-ms merged commit af5b5d3 into microsoft:master Apr 30, 2021
@autoantwort autoantwort deleted the linux-windows-cross-compile branch September 1, 2021 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants