Skip to content

[vcpkg/scripts/make] avoid versioning for android#17089

Merged
vicroms merged 1 commit intomicrosoft:masterfrom
huangqinjin:make-remove-soname-for-android
Jul 26, 2021
Merged

[vcpkg/scripts/make] avoid versioning for android#17089
vicroms merged 1 commit intomicrosoft:masterfrom
huangqinjin:make-remove-soname-for-android

Conversation

@huangqinjin
Copy link
Contributor

No description provided.

@JackBoosY
Copy link
Contributor

cc @Neumann-A @vicroms

@JackBoosY JackBoosY self-assigned this Apr 5, 2021
@JackBoosY JackBoosY added the category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly label Apr 5, 2021
@Neumann-A
Copy link
Contributor

Looks valid? Don't know any details about this. But we probably need some kind of VCPKG_<variable> to pass additional libtool flags?

@JackBoosY
Copy link
Contributor

Waiting for #17083 merge.

@vicroms
Copy link
Member

vicroms commented Apr 6, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JackBoosY
Copy link
Contributor

Please get failure logs here.

@huangqinjin
Copy link
Contributor Author

This PR is only for android triplets, the failure log seems irrelevant.

@vicroms
Copy link
Member

vicroms commented Apr 7, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JackBoosY
Copy link
Contributor

Depends on #17227

@JackBoosY JackBoosY added the depends:different-pr This PR or Issue depends on a PR which has been filed label Apr 14, 2021
@JackBoosY
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JackBoosY JackBoosY added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Jul 26, 2021
@vicroms vicroms merged commit 56a33d8 into microsoft:master Jul 26, 2021
@huangqinjin huangqinjin deleted the make-remove-soname-for-android branch December 14, 2021 14:08
@dg0yt
Copy link
Contributor

dg0yt commented May 13, 2023

@huangqinjin Which ports did you test this with? The flag is passed into configure here. configure doesn't use libtool, it actually generates it. Now it is starting to create problems: #31332.

@huangqinjin
Copy link
Contributor Author

@dg0yt libbacktrace. Actually libtool is totally unusable currently. There is an unfinished work in #17088. If -avoid-version is causing problem, please simply revert this commit.

@dg0yt
Copy link
Contributor

dg0yt commented May 13, 2023

libbacktrace.

I will try this. Thanks.

Actually libtool is totally unusable currently. There is an unfinished work in #17088. If -avoid-version is causing problem, please simply revert this commit.

Note that the static android triplets do work on windows now. I had to fix vpckg's use of msys2 for this.

@huangqinjin
Copy link
Contributor Author

Note that the static android triplets do work on windows now.

Yeah, only shared libraries do not work, as libtool strips out --target link flags, that is what I fixed in #17088 (though abandoned finally).

@dg0yt dg0yt mentioned this pull request May 13, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly depends:different-pr This PR or Issue depends on a PR which has been filed info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants