[vcpkg] improve pull request template#17049
Merged
vicroms merged 2 commits intomicrosoft:masterfrom Apr 12, 2021
Merged
Conversation
ras0219-msft
reviewed
Apr 2, 2021
ras0219-msft
approved these changes
Apr 2, 2021
Co-authored-by: Robert Schumacher <roschuma@microsoft.com>
Contributor
Author
|
The download of cmake failed, can you rerun the pipeline? :) |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
JackBoosY
added
the
category:vcpkg-feature
JackBoosY
approved these changes
Apr 5, 2021
Contributor
|
LGTM. |
JackBoosY
added
the
info:needs-maintainer-attention
PhoebeHui
changed the title
Contributor
|
The CI failures has gone after rerun. They are unrelate to this changes. @autoantwort, thanks for the PR! |
PhoebeHui
approved these changes
Apr 6, 2021
Contributor
|
Marking requires:discussion so we can go over the wording tomorrow just to make sure we don't have anything we want changed slightly. |
Contributor
Author
What was the result. Should I change something? :) |
Contributor
|
Nope, we'll have a discuss. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the pull request
Imho the current template is sometimes hard to read because the answers are behind the question.
I have also added the question if the person has executed
./vcpkg x-add-version --allbecause a lot of people misses that.