[sdl2] Re-enable ibus in build#29607
Merged
JavierMatosD merged 2 commits intomicrosoft:masterfrom Feb 13, 2023
Merged
Conversation
Contributor
Author
|
@microsoft-github-policy-service agree |
Contributor
|
This change isn't sufficient.
I wouldn't say system package dependencies are unacceptable, but at least they should be limited and scoped by an optional feature. And the user should be made aware of it. |
Contributor
Author
|
I'm fine with introducing some warning messages like the package currently does for Wayland/X11, but please understand that this is only bringing the ibus system up to par with the rest of the port. Many of the current features of SDL2 are still depended upon system libraries. |
This was disabled in microsoft#14275 because it caused the relevant libraries (ibus, glib, ...) to be depended on transitively. Nowadays, SDL2 loads these completely at runtime, only needing the headers and such at compile time, so it's safe to re-enable this again. Ibus is gated behind the "ibus" feature, which like the existing x11/wayland ones warn at installation that you need the necessary system packages to use it. The ibus feature is enabled by default.
FrankXie05
added
the
category:port-feature
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
FrankXie05
approved these changes
Feb 13, 2023
| message(WARNING "You will need to install Wayland dependencies to use feature wayland:\nsudo apt install libwayland-dev libxkbcommon-dev libegl1-mesa-dev\n") | ||
| endif() | ||
| if ("ibus" IN_LIST FEATURES) | ||
| message(WARNING "You will need to install ibus dependencies to use feature ibus:\nsudo apt install libibus-1.0-dev\n") |
Contributor
There was a problem hiding this comment.
We can currently accept adding a warning message to require users to install system packages to use this feature. I will test this feature like dg0yt said.
FrankXie05
added
the
info:needs-maintainer-attention
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was disabled in #14275 because it caused the relevant libraries (ibus, glib, ...) to be depended on transitively.
Nowadays, SDL2 loads these completely at runtime, only needing the headers and such at compile time. It should be safe to re-enable this again.
./vcpkg x-add-version --alland committing the result.