Skip to content

[vcpkg baseline][paraview] Fix linux build#12144

Merged
BillyONeal merged 19 commits intomicrosoft:masterfrom
JackBoosY:dev/jack/fix_paraview_linux
Jun 30, 2020
Merged

[vcpkg baseline][paraview] Fix linux build#12144
BillyONeal merged 19 commits intomicrosoft:masterfrom
JackBoosY:dev/jack/fix_paraview_linux

Conversation

@JackBoosY
Copy link
Contributor

@JackBoosY JackBoosY commented Jun 29, 2020

  • Add feature tools
  • Add dependency embree3 to paraview on Linux.
  • Disable feature tools on OSX.

Other changes use @Neumann-A suggestion #11596 (comment).

Related: #12018 #12126 #11754 #12145 #12068 etc.

@JackBoosY JackBoosY added category:port-bug The issue is with a library, which is something the port should already support info:internal category:infrastructure Pertaining to the CI/Testing infrastrucutre labels Jun 29, 2020
This was referenced Jun 29, 2020
@JackBoosY JackBoosY changed the title [paraview] Fix linux build [vcpkg baseline][paraview] Fix linux build Jun 29, 2020
@JackBoosY JackBoosY marked this pull request as ready for review June 29, 2020 08:56
@JackBoosY JackBoosY requested a review from PhoebeHui June 29, 2020 08:57
@JackBoosY
Copy link
Contributor Author

Modify by my iPhone, OMG.

@JackBoosY
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 12144 in repo microsoft/vcpkg

@JackBoosY
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Neumann-A
Copy link
Contributor

@JackBoosY: Updating vtk to 9.0.1 also solves the hdf5 issue. see #12149. The libmath issues still exists but it is probably not due to VTK but some other dependent library.

@Neumann-A
Copy link
Contributor

@JackBoosY: [VCPKG-DEBUG]: Found libmath.a in embree3

@Neumann-A
Copy link
Contributor

Filled:
https://gitlab.kitware.com/paraview/paraview/-/issues/20043
PR can be closed since the temporary fix without patches is to add a build-depends on embree3

@BillyONeal
Copy link
Member

@Neumann-A Are you saying we should not merge this? I think it makes sense to merge it even if only to get the better hdf5 fix.

@BillyONeal BillyONeal merged commit 67ab613 into microsoft:master Jun 30, 2020
@JackBoosY JackBoosY deleted the dev/jack/fix_paraview_linux branch June 30, 2020 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:infrastructure Pertaining to the CI/Testing infrastrucutre category:port-bug The issue is with a library, which is something the port should already support

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants