[qt5] update qt to 5.15 and make ports depend on qt5-base[core]. by Neumann-A · Pull Request #11596 · microsoft/vcpkg

Neumann-A · 2020-05-26T16:12:56Z

and so it starts again ....

Figure out whats wrong with qt5-x11extras on linux again or try to figure out what is missing in CI (needs logs from qt5-base since that is the source of the error) (@JackBoosY: Could get CI logs for qt5-base:x64-linux?)
Try fixing qwt by upgrading to 6.1.4
Fix qt5-webengine again (~~lets see if ci is able to build it~~. @heydojo: Mind testing?)
Have somebody check the qt5-location:x64-windows-static regression (Cannot create parent directory) (seems to be a bit flaky had the error two times on my pc and i just retried. Maybe disable parallel build if too flaky for ci?)

Note for reviewers: The patches are the same as for Qt 5.14. I just removed the old 5.12.8 patches and renamed the patches from Qt 5.14

cenit · 2020-05-26T19:29:19Z

Why the qt5-base[core] edit? Without default features, it does not look necessary at all

Neumann-A · 2020-05-26T19:49:46Z

@cenit. Correctness. It should mostly always be <port>[core] if <port> can have some significant features. Also features for qt5-base are not unlikely since this are the possible options:
config_help.txt

…ing for more errors)

JackBoosY · 2020-05-27T02:14:34Z

Hmm...I can't get the log if there is no failure in the CI test.

ports/qt5-winextras/CONTROL

JackBoosY · 2020-05-27T02:44:46Z

Vcpkg has a bug when using [core] in Default-features. See #11602.

Co-authored-by: Jack·Boos·Yu <47264268+JackBoosY@users.noreply.github.com>

Neumann-A · 2020-05-27T07:00:30Z

@JackBoosY: That is not a bug but a feature of vcpkg. The user has to be explicit about what he wants if he don't want to have the default set of features (as written in the issue itself)

…ndle it now

Neumann-A · 2020-05-27T08:32:33Z

@JackBoosY: I don't think the Linux CI should be green qt5-x11extras is still failing in https://github.com/microsoft/vcpkg/runs/712070460

JackBoosY · 2020-05-27T09:50:08Z

Please get logs here.

Qt is now configured for building. Just run 'make'.
Once everything is built, you must run 'make install'.
Qt will be installed into '/mnt/_work/1/s/installed/x64-linux'.

Prior to reconfiguration, make sure you remove any leftovers from
the previous build.

I don't think that has error there, maybe just a misjudgment in vcpkg_configure_qmake or else.

Neumann-A · 2020-05-27T10:30:13Z

<snip> solved

Neumann-A · 2020-05-27T10:33:59Z

  X11 specific:
    XLib ................................. yes
    XCB Xlib ............................. yes
    EGL on X11 ........................... no
    xkbcommon-x11 ........................ yes

The egl checks fails and that is why EGL on X11 says no

Edit: Solved

BillyONeal · 2020-07-01T18:15:56Z

@Neumann-A VMs have been updated with your changes, dropping the depends:vm-update tag. If there are still CI regressions you'll want to look at those.

# Conflicts: # ports/paraview/portfile.cmake # ports/qt5-base/CONTROL # ports/qt5-base/portfile.cmake # scripts/ci.baseline.txt

…_5_15_0 # Conflicts: # ports/paraview/portfile.cmake # ports/qt5-base/portfile.cmake

Neumann-A · 2020-07-01T21:12:00Z

quickfix seems to be a bit flakky? (Why is it even rebuild here it only depends on openssl?)

Since linux and windows are already green I assume the same for osx. I highly recommend to make paraview tools a default feature if the embree issue in netCDF is resolved to make paraview a test of Qt.
If this is merged I'll finish the cmake PR which can be used as a second test to see if Qt is properly built/linking.

BillyONeal · 2020-07-01T23:17:48Z

Quickfix is broken in master right now, your change is an innocent bystander. @JackBoosY you were previously 'Request Changes' on this PR, does it look good to you now?

@Neumann-A Thanks for your contribution!

BillyONeal · 2020-07-03T04:44:02Z

/azp run

azure-pipelines · 2020-07-03T04:44:11Z

Azure Pipelines successfully started running 1 pipeline(s).

BillyONeal · 2020-07-05T05:47:19Z

/azp run

azure-pipelines · 2020-07-05T05:47:29Z

Azure Pipelines successfully started running 1 pipeline(s).

Neumann-A · 2020-07-05T22:44:46Z

@BillyONeal: Please rerun x64-windows. error is:
D:/installed/x64-windows/tools/qt5/debug/mkspecs/features/qt_plugin.prf:59: Cannot write file D:\buildtrees\qt5-imageformats\x64-windows-dbg\mkspecs\modules-inst\qt_plugin_qwebp.pri: Cannot create parent directory
Happens sometimes don't know why but retrying typically solves it.

JackBoosY · 2020-07-06T05:49:05Z

Due to the long duration of the PR and the long test time, the format problem can be waited for the next update and fix.

ras0219-msft · 2020-07-08T22:34:59Z

It is merged!

Thank you @Neumann-A once again for the marathon of effort required to pilot the Qt ship :)

BillyONeal · 2020-07-08T22:43:09Z

THANK YOU!!!!!!!

JackBoosY · 2020-07-09T02:20:44Z

Thanks for your hard work @Neumann-A!

Neumann-A added 2 commits May 26, 2020 17:59

[qt5] update qt to 5.15 and make ports depend on qt5-base[core].

005421f

[qt5] update and remove patches

3a1e842

Neumann-A added 3 commits May 26, 2020 21:37

[baseline] skip qt5-canvas3d due to deprecation

97f3f8e

[qwt] update to 6.1.4 and fix build issues

5a4db7c

[qt5-webengine] remove old patches

277f70a

Neumann-A added 4 commits May 26, 2020 21:56

[qwt] fix static patch

5423d88

[qt5-location] add a message that the port has a sprious failure

64a8fd4

[qt5-webengine] fix filename of patch

9f51329

[qt5-webengine] add build.patch (ci is probably fast than me in check…

0a291f8

…ing for more errors)

Neumann-A mentioned this pull request May 26, 2020

[VCPKG|CI] Not reporting regression in subsequent CI reruns #11600

Closed

NancyLi1013 requested a review from JackBoosY May 27, 2020 01:51

NancyLi1013 assigned JackBoosY May 27, 2020

JackBoosY suggested changes May 27, 2020

View reviewed changes

ports/qt5-winextras/CONTROL Outdated Show resolved Hide resolved

Neumann-A and others added 2 commits May 27, 2020 08:57

[qt5-winextras] depend on qt5-base[core]

93d5c7b

Co-authored-by: Jack·Boos·Yu <47264268+JackBoosY@users.noreply.github.com>

[qt5-base] update latest feature (latest=core)

3783485

Neumann-A added 2 commits May 27, 2020 09:02

[baseline] remove qt5-webengine for nonstatic windows since CI can ha…

593db72

…ndle it now

[qt5-base] make qt5-base fail to get logs.

feae0d0

Neumann-A added 4 commits May 27, 2020 14:42

[angle] include missing egl sources.

af9d8e2

[qt5-base] patch egl detection logic.

bc6cd87

[baseline] remove qt-x11extras:x64-linux=fail

2a427b3

[qt5-base] need to be explicit about xcb to build qt5-x11extras

9de2697

BillyONeal removed the depends:vm-update PR contains changes to the VM provisioning scripts label Jul 1, 2020

Neumann-A added 3 commits July 1, 2020 20:22

Merge remote-tracking branch 'upstream/master' into update_qt_5_15_0

09cff36

# Conflicts: # ports/paraview/portfile.cmake # ports/qt5-base/CONTROL # ports/qt5-base/portfile.cmake # scripts/ci.baseline.txt

Merge remote-tracking branch 'origin/update_qt_5_15_0' into update_qt…

4361a98

…_5_15_0 # Conflicts: # ports/paraview/portfile.cmake # ports/qt5-base/portfile.cmake

[qt5-base] forgot to add the patch

b5839ec

BillyONeal requested a review from JackBoosY July 1, 2020 23:17

JackBoosY approved these changes Jul 6, 2020

View reviewed changes

JackBoosY added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Jul 6, 2020

Neumann-A added 2 commits July 8, 2020 01:00

Delete 6943.diff

34f96ce

Merge branch 'master' into update_qt_5_15_0

5e417f6

JackBoosY requested a review from ras0219-msft July 8, 2020 08:43

ras0219-msft merged commit 3bffe1c into microsoft:master Jul 8, 2020

cenit mentioned this pull request Jul 9, 2020

[qt5-base:x64-windows] build failure #12341

Closed

ras0219-msft mentioned this pull request Jul 9, 2020

add feature build vtk[qtopengl] #10060

Closed

davidebeatrici mentioned this pull request Jul 14, 2020

[qt5-base] libx11-xcb-dev is not the only package required for the GUI components #11727

Closed

Neumann-A deleted the update_qt_5_15_0 branch July 17, 2020 19:25

Conversation

Neumann-A commented May 26, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cenit commented May 26, 2020

Uh oh!

Neumann-A commented May 26, 2020

Uh oh!

JackBoosY commented May 27, 2020

Uh oh!

Uh oh!

JackBoosY commented May 27, 2020

Uh oh!

Neumann-A commented May 27, 2020

Uh oh!

Neumann-A commented May 27, 2020

Uh oh!

JackBoosY commented May 27, 2020

Uh oh!

Neumann-A commented May 27, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Neumann-A commented May 27, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

BillyONeal commented Jul 1, 2020

Uh oh!

Neumann-A commented Jul 1, 2020

Uh oh!

BillyONeal commented Jul 1, 2020

Uh oh!

BillyONeal commented Jul 3, 2020

Uh oh!

azure-pipelines bot commented Jul 3, 2020

Uh oh!

BillyONeal commented Jul 5, 2020

Uh oh!

azure-pipelines bot commented Jul 5, 2020

Uh oh!

Neumann-A commented Jul 5, 2020

Uh oh!

JackBoosY commented Jul 6, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ras0219-msft commented Jul 8, 2020

Uh oh!

BillyONeal commented Jul 8, 2020

Uh oh!

JackBoosY commented Jul 9, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Neumann-A commented May 26, 2020 •

edited

Loading

Neumann-A commented May 27, 2020 •

edited

Loading

Neumann-A commented May 27, 2020 •

edited

Loading

JackBoosY commented Jul 6, 2020 •

edited

Loading