[libffi] Add pkgconfig file#12126
Merged
ras0219-msft merged 2 commits intomicrosoft:masterfrom Jul 6, 2020
Merged
Conversation
- Configure and add the libffi.pc file. - Furthermore, enable the check for same 32/64bit-ness in libffiConfigVersion.cmake again, which had caused issues in the past with newer versions of glib using meson build, e.g. when building for x86-windows target on an x64-windows host. Now, libffi is found by current glib (e.g. 2.64.3) during meson build using the libffi pkgconfig file.
vicroms
approved these changes
Jun 26, 2020
vicroms
added
the
info:needs-maintainer-attention
Contributor
Author
|
Info concerning ninja: error: '/mnt/vcpkg-ci/installed/x64-linux/lib/libmath.a', needed by 'bin/pvserver', missing and no known rule to make itEdit: PR #12144 is about fixing |
LilyWangL
approved these changes
Jun 29, 2020
LilyWangL
added
the
category:port-feature
Contributor
|
LGTM, thanks for the improvement! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the pull request
What does your PR fix? Fixes #
libffi.pcfile.libffiConfigVersion.cmake again, which had caused issues in the past
with newer versions of glib using meson build, e.g. when building for
x86-windows target on an x64-windows host.
Now,
libffiis found by currentglib(e.g. 2.64.3) duringmeson build using the libffi pkgconfig file.
Which triplets are supported/not supported? Have you updated the CI baseline?
All triplets are supported. CI baseline: no update required.
Does your PR follow the maintainer guide?
Yes