Skip to content

[ace] Fix missing cpp files#11713

Merged
dan-shaw merged 31 commits intomicrosoft:masterfrom
jwillemsen:jwi-ace-installcpp
Jun 3, 2020
Merged

[ace] Fix missing cpp files#11713
dan-shaw merged 31 commits intomicrosoft:masterfrom
jwillemsen:jwi-ace-installcpp

Conversation

@jwillemsen
Copy link
Contributor

Install all cpp files, we have a lot of source files with inline methods. At some point we should try to use the MPC prj_install support as alternative

    * ports/ace/portfile.cmake:
    * ports/ace/portfile.cmake:
    * ports/ace/portfile.cmake:
    * ports/ace/portfile.cmake:
    * ports/ace/portfile.cmake:
    * ports/ace/portfile.cmake:
    * ports/ace/process_manager.patch:
      Added.

    * ports/ace/CONTROL:
    * ports/ace/portfile.cmake:
    * ports/ace/portfile.cmake:
    * ports/ace/portfile.cmake:
    * ports/ace/process_manager.patch:
    * ports/ace/portfile.cmake:
    * scripts/ci.baseline.txt:
    * ports/ace/CONTROL:
@JackBoosY JackBoosY self-assigned this Jun 2, 2020
Copy link
Contributor

@JackBoosY JackBoosY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the version info. See documentation.

@jwillemsen jwillemsen requested a review from JackBoosY June 2, 2020 06:08
@JackBoosY
Copy link
Contributor

JackBoosY commented Jun 2, 2020

The osg regression is fixing in #11715.

@jwillemsen jwillemsen changed the title Fix missing ACE cpp files [ace] Fix missing cpp files Jun 2, 2020
@BillyONeal
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JackBoosY JackBoosY added category:port-bug The issue is with a library, which is something the port should already support info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. labels Jun 3, 2020
@dan-shaw dan-shaw merged commit 77f46d4 into microsoft:master Jun 3, 2020
@jwillemsen jwillemsen deleted the jwi-ace-installcpp branch June 3, 2020 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-bug The issue is with a library, which is something the port should already support info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ace: Missing installed header ace/Intrusive_List.cpp

4 participants