[vcpkg] Onboard Linux to VMSS, open 'git' port, and switch back to Azure Spot by BillyONeal · Pull Request #10980 · microsoft/vcpkg

BillyONeal · 2020-04-23T09:53:18Z

Adds scripts to generate scale sets for testing Linux.
- Note workaround for libcurl3 still exists on Ubuntu 18.04 servers azure-pipelines-agent#2929
Switches Windows validation to 'Spot' VMs.
Opens the git port 9418.
Removes provisioning of the no longer used 'logs' file share.
Changes Azure region to 'westus2', which is cheaper.
Adds +x to all the scripts in scripts/azure-pipelines.
Use 'xml-results' for all platforms instead of 'raw xml results' on Windows.

BillyONeal · 2020-04-25T02:02:48Z

/azp run

azure-pipelines · 2020-04-25T02:02:57Z

Azure Pipelines successfully started running 1 pipeline(s).

JackBoosY · 2020-04-26T08:46:38Z

/azp run

azure-pipelines · 2020-04-26T08:46:46Z

Azure Pipelines failed to run 1 pipeline(s).

BillyONeal · 2020-04-28T04:09:06Z

/azp run

azure-pipelines · 2020-04-28T04:09:15Z

Azure Pipelines successfully started running 1 pipeline(s).

scripts/azure-pipelines/macos/azure-pipelines.yml

scripts/azure-pipelines/windows/create-vmss.ps1

strega-nil

Looks good, just got some minor suggestions and questions :)

Also, what's going on with analyze-test-results.ps1 and generate-skip-list.ps1? they have different permissions now, maybe? is there a reason for that?

strega-nil · 2020-04-30T23:28:04Z

ports/openblas/portfile.cmake

This should probably use a git hash

Why is that?

strega-nil · 2020-04-30T23:35:24Z

ports/qt-advanced-docking-system/skip_license_install.patch

what's the diff here?

Probably trailing whitespace VS Code automatically deleted when I saved the change :/

strega-nil · 2020-04-30T23:35:41Z

ports/qt-advanced-docking-system/skip_license_install.patch

what's the diff here?

Ditto probably trailing whitespace

strega-nil · 2020-04-30T23:36:00Z

ports/qt-advanced-docking-system/skip_license_install.patch

what's the diff here?

Ditto trailing whitespace

strega-nil · 2020-04-30T23:36:11Z

ports/qt-advanced-docking-system/skip_license_install.patch

please remove this.

ports/ceres/portfile.cmake

BillyONeal · 2020-05-01T01:08:01Z

ports/openblas/portfile.cmake

Why is that?

BillyONeal · 2020-05-01T01:08:18Z

ports/qt-advanced-docking-system/skip_license_install.patch

Probably trailing whitespace VS Code automatically deleted when I saved the change :/

BillyONeal · 2020-05-01T01:08:26Z

ports/qt-advanced-docking-system/skip_license_install.patch

Ditto probably trailing whitespace

BillyONeal · 2020-05-01T01:08:33Z

ports/qt-advanced-docking-system/skip_license_install.patch

Ditto trailing whitespace

BillyONeal · 2020-05-01T01:09:20Z

Also, what's going on with analyze-test-results.ps1 and generate-skip-list.ps1? they have different permissions now, maybe? is there a reason for that?

chmod +x :)

…ure Spot * Adds scripts to generate scale sets for testing Linux. * Note workaround for microsoft/azure-pipelines-agent#2929 * Switches Windows validation to 'Spot' VMs. * Opens the git port 9418. * Removes provisioning of the no longer used 'logs' file share. * Changes Azure region to 'westus2', which is cheaper. * Adds +x to all the scripts in scripts/azure-pipelines. * Use 'xml-results' for all platforms instead of 'raw xml results' on Windows.

…install LICENSE.

…es not exist on Windows.

…sent on the VMs)

… wherein 'python' is python2.

BillyONeal added the internal label Apr 23, 2020

BillyONeal self-assigned this Apr 23, 2020

BillyONeal marked this pull request as draft April 23, 2020 09:53

BillyONeal force-pushed the vmss_linux branch from 909c7cb to 5049207 Compare April 23, 2020 09:54

LilyWangL requested a review from ras0219-msft April 23, 2020 10:02

LilyWangL assigned JackBoosY Apr 23, 2020

LilyWangL requested a review from JackBoosY April 23, 2020 10:02

LilyWangL changed the title ~~Onboard Linux VMSS.~~ [vcpkg] Onboard Linux VMSS. Apr 23, 2020

BillyONeal force-pushed the vmss_linux branch 3 times, most recently from ddd65f9 to 3de77c8 Compare April 24, 2020 09:08

BillyONeal force-pushed the vmss_linux branch 3 times, most recently from 31c6854 to d254bb6 Compare April 26, 2020 02:16

BillyONeal mentioned this pull request Apr 28, 2020

[rtlsdr] Add new port #10901

Merged

BillyONeal force-pushed the vmss_linux branch 2 times, most recently from 777cd96 to 80f1c23 Compare April 28, 2020 22:11

BillyONeal changed the title ~~[vcpkg] Onboard Linux VMSS.~~ [vcpkg] Onboard Linux to VMSS, open 'git' port, and switch back to Azure Spot Apr 29, 2020

BillyONeal force-pushed the vmss_linux branch from 3533cc1 to 732f66a Compare April 29, 2020 05:16

BillyONeal marked this pull request as ready for review April 29, 2020 05:19

BillyONeal requested review from cbezault and strega-nil April 29, 2020 05:25

BillyONeal commented Apr 29, 2020

View reviewed changes

scripts/azure-pipelines/macos/azure-pipelines.yml Outdated Show resolved Hide resolved

BillyONeal commented Apr 29, 2020

View reviewed changes

scripts/azure-pipelines/windows/create-vmss.ps1 Outdated Show resolved Hide resolved

BillyONeal force-pushed the vmss_linux branch 12 times, most recently from 0f99830 to 5c2adfd Compare April 30, 2020 07:45

BillyONeal mentioned this pull request Apr 30, 2020

Don't install 'LICENSE' or 'README.md' directly to the installation directory. adishavit/argh#51

Merged

cbezault approved these changes Apr 30, 2020

View reviewed changes

BillyONeal force-pushed the vmss_linux branch from 5c2adfd to 939bb86 Compare April 30, 2020 18:34

strega-nil approved these changes Apr 30, 2020

View reviewed changes

BillyONeal commented May 1, 2020

View reviewed changes

BillyONeal added 5 commits April 30, 2020 20:26

[argh] Patch argh to not take the name 'license'.

4834f64

[qt-advanced-docking-system] Patch qt-advanced-docking-system to not …

ba3bdbf

…install LICENSE.

[idevicerestore] Mark as failing because it wants <libgen.h> which do…

614e65f

…es not exist on Windows.

[OpenBLAS] Upgrade to 0.3.9 + a patch to fix AVX512 (which is now pre…

94f2a88

…sent on the VMs)

BillyONeal force-pushed the vmss_linux branch 2 times, most recently from 43bafca to 50a6e6a Compare May 1, 2020 03:28

BillyONeal added 2 commits April 30, 2020 20:51

[Ceres] Set LIB_SUFFIX for Ceres to ensure portfile and build agree.

771db71

[glad] Pass path to python explicitly to work on default Ubuntu 18.04…

f39139d

… wherein 'python' is python2.

BillyONeal force-pushed the vmss_linux branch from 50a6e6a to f39139d Compare May 1, 2020 03:51

BillyONeal merged commit 28fc76e into microsoft:master May 1, 2020

BillyONeal deleted the vmss_linux branch May 1, 2020 04:51

Conversation

BillyONeal commented Apr 23, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

BillyONeal commented Apr 25, 2020

Uh oh!

azure-pipelines bot commented Apr 25, 2020

Uh oh!

JackBoosY commented Apr 26, 2020

Uh oh!

azure-pipelines bot commented Apr 26, 2020

Uh oh!

BillyONeal commented Apr 28, 2020

Uh oh!

azure-pipelines bot commented Apr 28, 2020

Uh oh!

Uh oh!

Uh oh!

strega-nil left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

BillyONeal commented May 1, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

BillyONeal commented Apr 23, 2020 •

edited

Loading