[rtlsdr] Add new port#10901
Merged
strega-nil merged 3 commits intomasterfrom May 7, 2020
unknown repository
Merged
Conversation
|
|
Contributor
|
Hi @echesakov, thanks for this PR! Thanks. |
ghost
marked this pull request as ready for review
Author
@JackBoosY I did, can you please re-run the ci? |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
It seems that the network segment where the pipeline machine is located cannot access this address. |
JackBoosY
suggested changes
Apr 26, 2020
JackBoosY
approved these changes
Apr 27, 2020
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
|
We firewall the git protocol at the moment (we allow only HTTP because we don't want a rogue PR to be able to turn our test fleet into spambots and that sort of thing). Is there an HTTP endpoint we can use or do we have to open that up? |
Member
|
#10980 will open that port |
Author
|
I have update the PR to use GitHub mirror https://github.com/osmocom/rtl-sdr |
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
Alright, this looks good! Thanks @echesakov :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does your PR fix? Fixes issue #
Nothing, this adds a new port for rtl-sdr - software that turns a Realtek RTL2832 based DVB dongle into a SDR receiver (https://osmocom.org/projects/rtl-sdr)
Which triplets are supported/not supported? Have you updated the CI baseline?
x86-windows and x64-windows are the only supported ones. Not yet.
Does your PR follow the maintainer guide?
Yes.