libcurl3 still exists on Ubuntu 18.04 servers#2929
libcurl3 still exists on Ubuntu 18.04 servers#2929krknopp wants to merge 2 commits intomicrosoft:masterfrom
Conversation
…ure Spot
* Adds scripts to generate scale sets for testing Linux.
* Note workaround for microsoft/azure-pipelines-agent#2929
* Switches Windows validation to 'Spot' VMs.
* Opens the git port 9418.
* Removes provisioning of the no longer used 'logs' file share.
* Changes Azure region to 'westus2', which is cheaper.
* Adds +x to all the scripts in scripts/azure-pipelines.
* Use 'xml-results' for all platforms instead of 'raw xml results' on Windows.
…ure Spot
* Adds scripts to generate scale sets for testing Linux.
* Note workaround for microsoft/azure-pipelines-agent#2929
* Switches Windows validation to 'Spot' VMs.
* Opens the git port 9418.
* Removes provisioning of the no longer used 'logs' file share.
* Changes Azure region to 'westus2', which is cheaper.
* Adds +x to all the scripts in scripts/azure-pipelines.
* Use 'xml-results' for all platforms instead of 'raw xml results' on Windows.
| # ubuntu 18 uses libcurl4 | ||
| # ubuntu 14, 16 and other linux use libcurl3 | ||
| apt install -y libcurl3 || apt install -y libcurl4 | ||
| if [ $(lsb_release -rs) = "18.04" ] |
There was a problem hiding this comment.
Should this check for 14 and 16 instead because future versions are going to use 4?
There was a problem hiding this comment.
There's a workaround btw. If you install libcurl4 first, then do: apt-mark hold libcurl4
That will prevent the crapfest that follows.
There was a problem hiding this comment.
Also, why not just reverse it? Otherwise you're going to have to continually keep adding future versions:
apt-get install -y libcurl4 || apt-get install -y libcurl3
krknopp
left a comment
krknopp
left a comment
There was a problem hiding this comment.
updated code to reflect comments.
|
@krknopp @BillyONeal Thanks for bringing this to our attention. I've reversed the order of the installs (#2998) to address the immediate issue on Ubuntu 18. I'm holding off on more sophisticated use of lsb_release as part of a larger refactoring effort. Sorry for the delay on this. The fix will be in the next release of the agent, which I'll begin the process of releasing shortly. |
4 participants
on our systems,
libcurl3is still available on Ubuntu 18.04 servers, so the script installslibcurl3, which forcescurlandlibcurl4to be removed.This change checks to see which version of Ubuntu the script is running on and then installs the appropriate version of
libcurl.