Merged
Conversation
Neumann-A
reviewed
Feb 13, 2020
| -list(APPEND PCL_LIBRARIES ${BOOST_LIBRARIES} ${QHULL_LIBRARIES} ${OPENNI_LIBRARIES} ${OPENNI2_LIBRARIES} ${ENSENSO_LIBRARIES} ${davidSDK_LIBRARIES} ${DSSDK_LIBRARIES} ${RSSDK_LIBRARIES} ${FLANN_LIBRARIES} ${VTK_LIBRARIES}) | ||
| +list(APPEND PCL_LIBRARIES ${BOOST_LIBRARIES} ${QHULL_LIBRARIES} ${OPENNI_LIBRARIES} ${OPENNI2_LIBRARIES} ${ENSENSO_LIBRARIES} ${davidSDK_LIBRARIES} ${DSSDK_LIBRARIES} ${RSSDK_LIBRARIES} flann::flann_cpp ${VTK_LIBRARIES}) | ||
| list(APPEND PCL_LIBRARIES ${BOOST_LIBRARIES} ${QHULL_LIBRARIES} ${OPENNI_LIBRARIES} ${OPENNI2_LIBRARIES} ${ENSENSO_LIBRARIES} ${davidSDK_LIBRARIES} ${DSSDK_LIBRARIES} ${RSSDK_LIBRARIES} ${RSSDK2_LIBRARIES} ${VTK_LIBRARIES}) | ||
| -if (TARGET FLANN::FLANN) |
Contributor
There was a problem hiding this comment.
Instead of patching all the FLANN::FLANN targets away. Do the following:
- do not remove FindFLANN.cmake
- make/patch FindFLANN to find the flann configs
- reroute the targets defined by the flann config (e.g. flann::flann_cpp) to be FLANN::FLANN via add_library(FLANN::FLANN ALIAS flann::flann_cpp)
doing it that way requires less patches
Contributor
Author
|
@Neumann-A When I try to build Any ideas? And I found that |
Contributor
|
Related issue #9765 |
Contributor
|
@Neumann-A No idea. Did not encounter that issue |
Merged
Contributor
Author
|
/azp run |
Contributor
|
@JackBoosY, could you reoslve conficts? |
JackBoosY
added
the
category:port-update
Contributor
|
Can we get a pcl 1.11.0 update? Boost is very up to date on vcpkg but it breaks the old 1.9.1 pcl. There are a lot of boost related fixes upstream in the newer version of pcls. |
Contributor
|
Probably should also add PointCloudLibrary/pcl#4096 as a patch so people don't complain about visualization missing |
added 2 commits
July 2, 2020 23:47
Contributor
Author
|
@Neumann-A There are too many changes, I think we should wait to merge them into pcl master. |
JackBoosY
added
depends:different-pr
Contributor
Author
|
Should wait for #12279 merge. |
JackBoosY
removed
the
depends:different-pr
JackBoosY
added
the
depends:different-pr
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
JackBoosY
removed
the
depends:different-pr
|
any update? |
Contributor
Author
|
@bpoebiapl Once all test passed, this PR will be merged. |
Closed
Member
|
Thanks for your contribution! |
|
thanks! |
remz1337
pushed a commit
to remz1337/vcpkg
that referenced
this pull request
Aug 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes:
Related: #9986
Note: All features passed in the following triplets test: