Skip to content

[eigen3] Fix eigen3 and cuda compatibility issue#12279

Merged
ras0219-msft merged 4 commits intomicrosoft:masterfrom
JackBoosY:dev/jack/fix_eigen_cuda
Jul 15, 2020
Merged

[eigen3] Fix eigen3 and cuda compatibility issue#12279
ras0219-msft merged 4 commits intomicrosoft:masterfrom
JackBoosY:dev/jack/fix_eigen_cuda

Conversation

@JackBoosY
Copy link
Contributor

@JackBoosY JackBoosY commented Jul 6, 2020

Fix issue when using eigen3:

f:\vcpkg\installed\x64-windows\include\eigen3\eigen\src/Core/arch/CUDA/Half.h(212): error: more than one instance of overloaded function "__hadd" matches the argument list:
            function "__hadd(int, int)"
            function "__hadd(__half, __half)"
            argument types are: (const Eigen::half, const Eigen::half)

Using the official patch: https://eigen.tuxfamily.org/bz/show_bug.cgi?id=1526

@JackBoosY JackBoosY added category:port-bug The issue is with a library, which is something the port should already support info:internal labels Jul 6, 2020
@JackBoosY JackBoosY mentioned this pull request Jul 6, 2020
Merged
JackBoosY
JackBoosY commented Jul 6, 2020
View reviewed changes
@JackBoosY JackBoosY marked this pull request as ready for review July 7, 2020 02:13
@JackBoosY JackBoosY requested a review from NancyLi1013 July 7, 2020 02:13
@NancyLi1013 NancyLi1013 added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Jul 7, 2020
ras0219-msft
ras0219-msft reviewed Jul 7, 2020
View reviewed changes
JackBoosY
JackBoosY commented Jul 8, 2020
View reviewed changes
@JackBoosY JackBoosY requested a review from ras0219-msft July 9, 2020 06:08
@ras0219-msft ras0219-msft merged commit e59e5a4 into microsoft:master Jul 15, 2020
@JackBoosY JackBoosY deleted the dev/jack/fix_eigen_cuda branch July 16, 2020 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ras0219-msft ras0219-msft Awaiting requested review from ras0219-msft

2 more reviewers

@strega-nil strega-nil strega-nil approved these changes

@NancyLi1013 NancyLi1013 NancyLi1013 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@NancyLi1013 NancyLi1013

Labels

category:port-bug The issue is with a library, which is something the port should already support info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JackBoosY @strega-nil @ras0219-msft @NancyLi1013