-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable dropped_features for error analysis, data explorer and explainer, counterfactual and causal managers #1824
Conversation
Signed-off-by: Gaurav Gupta <[email protected]>
Signed-off-by: Gaurav Gupta <[email protected]>
Signed-off-by: Gaurav Gupta <[email protected]>
Signed-off-by: Gaurav Gupta <[email protected]>
Signed-off-by: Gaurav Gupta <[email protected]>
Signed-off-by: Gaurav Gupta <[email protected]>
Signed-off-by: Gaurav Gupta <[email protected]>
Signed-off-by: Gaurav Gupta <[email protected]>
Signed-off-by: Gaurav Gupta <[email protected]> Signed-off-by: Gaurav Gupta <[email protected]> Signed-off-by: Gaurav Gupta <[email protected]>
* Add model wrapper for wrapping predictions and test data Signed-off-by: Gaurav Gupta <[email protected]> * Fix failing tests Signed-off-by: Gaurav Gupta <[email protected]> Signed-off-by: Gaurav Gupta <[email protected]>
…ortance (#1770) Signed-off-by: Gaurav Gupta <[email protected]> Signed-off-by: Gaurav Gupta <[email protected]>
* Port tests Signed-off-by: Gaurav Gupta <[email protected]> * Fix rai_insights Signed-off-by: Gaurav Gupta <[email protected]> Signed-off-by: Gaurav Gupta <[email protected]>
* Simply tests in test_cohort_filter.py Signed-off-by: Gaurav Gupta <[email protected]> * Change test name Signed-off-by: Gaurav Gupta <[email protected]> Signed-off-by: Gaurav Gupta <[email protected]>
* Move cohort re-labelling logic to Cohort.ts Signed-off-by: Gaurav Gupta <[email protected]> * Lint fix Signed-off-by: Gaurav Gupta <[email protected]> * Lint fix Signed-off-by: Gaurav Gupta <[email protected]> Signed-off-by: Gaurav Gupta <[email protected]>
…nceView (#1775) * Refactor DataAnalysisTab into Chartview/DataAnalysisView and DataBalanceView Signed-off-by: Gaurav Gupta <[email protected]> * Fix lint Signed-off-by: Gaurav Gupta <[email protected]> Signed-off-by: Gaurav Gupta <[email protected]>
… highcharts (#1783) * enable csv xls download in hightcharts * localization
Signed-off-by: Gaurav Gupta <[email protected]> Signed-off-by: Gaurav Gupta <[email protected]>
* Add rai_test_utils package Signed-off-by: Gaurav Gupta <[email protected]> * Lint fix and namespace changes Signed-off-by: Gaurav Gupta <[email protected]> * Fix duplicated cohorts not retaining the selection in combobox (#1785) * fix and e2e Signed-off-by: vinutha karanth <[email protected]> * update filter Signed-off-by: vinutha karanth <[email protected]> Signed-off-by: vinutha karanth <[email protected]> * release raiwidgets and responsibleai 0.23.0 (#1787) * fix release github action for raiwidgets and responsibleai by making it same as in gated build (#1788) * Add e2e for dependency plot Avg of abs value option (#1768) * fix dep plot Signed-off-by: vinutha karanth <[email protected]> * add e2e Signed-off-by: vinutha karanth <[email protected]> * lintfix Signed-off-by: vinutha karanth <[email protected]> * lintfix Signed-off-by: vinutha karanth <[email protected]> Signed-off-by: vinutha karanth <[email protected]> * update e2e visit function (#1792) * Fix code review comments Signed-off-by: Gaurav Gupta <[email protected]> Signed-off-by: Gaurav Gupta <[email protected]> Signed-off-by: vinutha karanth <[email protected]> Co-authored-by: Vinutha Karanth <[email protected]> Co-authored-by: Ilya Matiach <[email protected]> Co-authored-by: tongy-msft <[email protected]>
Signed-off-by: vinutha karanth <[email protected]> Signed-off-by: vinutha karanth <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved with some nits
Codecov Report
@@ Coverage Diff @@
## main #1824 +/- ##
==========================================
+ Coverage 82.82% 88.60% +5.77%
==========================================
Files 55 96 +41
Lines 2935 5547 +2612
==========================================
+ Hits 2431 4915 +2484
- Misses 504 632 +128
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
...AssessmentDashboard/Controls/IndividualFeatureImportanceView/TabularLocalImportancePlots.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving since these are all minor comments.
@@ -82,6 +82,35 @@ def as_error_config(json_dict): | |||
return json_dict | |||
|
|||
|
|||
class MetadataRemovalModelWrapper(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this go into mlwrappers
eventually? @imatiach-msft
Note: this is not a blocker for this PR regardless of the answer.
This PR adds dropped_features and pass dropped_features to error analysis, data explorer and explainer managers if there is any.
GIF:

in the below regression example, we dropped ["s1", "s5"] features:
for counterfactual:

for causal:

Description
We will update the example notebooks, doc and add more tests in my next PR.
Checklist