Fix model wrapper to identify model type, remove task type from error analysis #1912
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue that blocks curated image release and other RAI repo releases.
Description
The issue is, the model wrapper created in PR #1824 has both predict function and predict_proba function. In error analysis, we check if the model has predict_proba function to identify if it is a classification model or regression model. In the case model is wrapped, it will always identify the model as classification model.
The fix is, we check if the model is classification model or regression model, and wrap the model in a separate function. So regression model won't have predict_proba function after wrapping. In this case, we don't need to specifically pass task_type into error_analysis_manager. So this PR also removes task_type from error_analysis_manager
Checklist