Fix TypeError: Cannot read properties of undefined (reading 'sort') #1798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: vinutha karanth <[email protected]>
vinuthakaranth
requested review from
romanlutz,
xuke444,
tongyu-microsoft and
RubyZ10
as code owners
gaugup
approved these changes
Nov 1, 2022
imatiach-msft
approved these changes
Nov 1, 2022
Codecov Report
@@ Coverage Diff @@
## main #1798 +/- ##
===========================================
+ Coverage 73.78% 87.53% +13.74%
===========================================
Files 25 96 +71
Lines 1274 5390 +4116
===========================================
+ Hits 940 4718 +3778
- Misses 334 672 +338
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
tongyu-microsoft
approved these changes
Nov 1, 2022
gaugup
pushed a commit
that referenced
this pull request
Nov 1, 2022
Signed-off-by: vinutha karanth <[email protected]> Signed-off-by: vinutha karanth <[email protected]>
gaugup
added a commit
that referenced
this pull request
Nov 18, 2022
* Add postga build trigger (#1755) (#1756) Signed-off-by: Gaurav Gupta <[email protected]> Signed-off-by: Gaurav Gupta <[email protected]> Signed-off-by: Gaurav Gupta <[email protected]> * Add model wrapper for wrapping predictions and test data (#1762) * Add model wrapper for wrapping predictions and test data Signed-off-by: Gaurav Gupta <[email protected]> * Fix failing tests Signed-off-by: Gaurav Gupta <[email protected]> Signed-off-by: Gaurav Gupta <[email protected]> * Change description of cohort selection panel in Aggregate Feature Importance (#1770) Signed-off-by: Gaurav Gupta <[email protected]> Signed-off-by: Gaurav Gupta <[email protected]> * Support cohort filtering of string target in rai_insights (#1771) * Port tests Signed-off-by: Gaurav Gupta <[email protected]> * Fix rai_insights Signed-off-by: Gaurav Gupta <[email protected]> Signed-off-by: Gaurav Gupta <[email protected]> * Simplify tests in test_cohort_filter.py (#1772) * Simply tests in test_cohort_filter.py Signed-off-by: Gaurav Gupta <[email protected]> * Change test name Signed-off-by: Gaurav Gupta <[email protected]> Signed-off-by: Gaurav Gupta <[email protected]> * Move cohort re-labelling logic to Cohort.ts (#1773) * Move cohort re-labelling logic to Cohort.ts Signed-off-by: Gaurav Gupta <[email protected]> * Lint fix Signed-off-by: Gaurav Gupta <[email protected]> * Lint fix Signed-off-by: Gaurav Gupta <[email protected]> Signed-off-by: Gaurav Gupta <[email protected]> * Update requirements.txt (#1779) * Refactor DataAnalysisTab into Chartview/DataAnalysisView and DataBalanceView (#1775) * Refactor DataAnalysisTab into Chartview/DataAnalysisView and DataBalanceView Signed-off-by: Gaurav Gupta <[email protected]> * Fix lint Signed-off-by: Gaurav Gupta <[email protected]> Signed-off-by: Gaurav Gupta <[email protected]> * [Highcharts] Enable csv download, xls download and view data table in highcharts (#1783) * enable csv xls download in hightcharts * localization * Add new data APIs for compute_matrix() and compute_error_tree() (#1790) Signed-off-by: Gaurav Gupta <[email protected]> Signed-off-by: Gaurav Gupta <[email protected]> * update e2e visit function (#1792) * Add rai_test_utils package (#1777) * Add rai_test_utils package Signed-off-by: Gaurav Gupta <[email protected]> * Lint fix and namespace changes Signed-off-by: Gaurav Gupta <[email protected]> * Fix duplicated cohorts not retaining the selection in combobox (#1785) * fix and e2e Signed-off-by: vinutha karanth <[email protected]> * update filter Signed-off-by: vinutha karanth <[email protected]> Signed-off-by: vinutha karanth <[email protected]> * release raiwidgets and responsibleai 0.23.0 (#1787) * fix release github action for raiwidgets and responsibleai by making it same as in gated build (#1788) * Add e2e for dependency plot Avg of abs value option (#1768) * fix dep plot Signed-off-by: vinutha karanth <[email protected]> * add e2e Signed-off-by: vinutha karanth <[email protected]> * lintfix Signed-off-by: vinutha karanth <[email protected]> * lintfix Signed-off-by: vinutha karanth <[email protected]> Signed-off-by: vinutha karanth <[email protected]> * update e2e visit function (#1792) * Fix code review comments Signed-off-by: Gaurav Gupta <[email protected]> Signed-off-by: Gaurav Gupta <[email protected]> Signed-off-by: vinutha karanth <[email protected]> Co-authored-by: Vinutha Karanth <[email protected]> Co-authored-by: Ilya Matiach <[email protected]> Co-authored-by: tongy-msft <[email protected]> * sort fix (#1798) Signed-off-by: vinutha karanth <[email protected]> Signed-off-by: vinutha karanth <[email protected]> * [LogarithmicScaling] Enable log scaling for data explorer, feature importance, counterfactual and casual (#1802) * update checkbox to toggle in axis config panel * support log toggle for counterfactual * enable log scaling for feature importance * enable log scaling for casual and data explorer * address comment * Update CODEOWNERS (#1805) * Fix ‘Close button’ and ‘Spin button’ present in new cohort dialog does not have any title or aria-label (#1806) * add aria label Signed-off-by: vinutha karanth <[email protected]> * address comment Signed-off-by: vinutha karanth <[email protected]> Signed-off-by: vinutha karanth <[email protected]> * Update erroranalysis tests to use new rai_test_utils package (#1800) * Update erroranalysis tests to use new rai_test_utils package Signed-off-by: Gaurav Gupta <[email protected]> * Remove shap and xgboost from test requirements Signed-off-by: Gaurav Gupta <[email protected]> * Pin rai_test_utils Signed-off-by: Gaurav Gupta <[email protected]> Signed-off-by: Gaurav Gupta <[email protected]> * Fix Heatmap tooltip theme (#1808) * fix tooltip color Signed-off-by: vinutha karanth <[email protected]> * fix theme Signed-off-by: vinutha karanth <[email protected]> * fix Signed-off-by: vinutha karanth <[email protected]> * rev Signed-off-by: vinutha karanth <[email protected]> Signed-off-by: vinutha karanth <[email protected]> * Calculate RAI insights for first 5K samples (#1803) Signed-off-by: Gaurav Gupta <[email protected]> Signed-off-by: Gaurav Gupta <[email protected]> * Add API for indicating large data scenario in ModelAssessmentContext (#1804) * [WIP] Add APIs for indicating large data scenario in ModelAssessmentContext Signed-off-by: Gaurav Gupta <[email protected]> * Change API name Signed-off-by: Gaurav Gupta <[email protected]> * Add unit test Signed-off-by: Gaurav Gupta <[email protected]> * Fix lint Signed-off-by: Gaurav Gupta <[email protected]> * Fix lint again Signed-off-by: Gaurav Gupta <[email protected]> Signed-off-by: Gaurav Gupta <[email protected]> * Add RAI version number to oss serialize result (#1812) * Add RAI version number to oss serialize result * update json file namg * add test Signed-off-by: Gaurav Gupta <[email protected]> Signed-off-by: vinutha karanth <[email protected]> Co-authored-by: tongy-msft <[email protected]> Co-authored-by: Vinutha Karanth <[email protected]> Co-authored-by: Ilya Matiach <[email protected]>
tongyu-microsoft
added a commit
that referenced
this pull request
Dec 7, 2022
…er, counterfactual and causal managers (#1824) * Add initial code for supporting dropped features Signed-off-by: Gaurav Gupta <[email protected]> * Fix Signed-off-by: Gaurav Gupta <[email protected]> * Fix causal path Signed-off-by: Gaurav Gupta <[email protected]> * Validate counerfactual scenario Signed-off-by: Gaurav Gupta <[email protected]> * Fix UI build Signed-off-by: Gaurav Gupta <[email protected]> * Add postga build trigger (#1755) (#1756) Signed-off-by: Gaurav Gupta <[email protected]> Signed-off-by: Gaurav Gupta <[email protected]> Signed-off-by: Gaurav Gupta <[email protected]> * Add model wrapper for wrapping predictions and test data (#1762) * Add model wrapper for wrapping predictions and test data Signed-off-by: Gaurav Gupta <[email protected]> * Fix failing tests Signed-off-by: Gaurav Gupta <[email protected]> Signed-off-by: Gaurav Gupta <[email protected]> * Change description of cohort selection panel in Aggregate Feature Importance (#1770) Signed-off-by: Gaurav Gupta <[email protected]> Signed-off-by: Gaurav Gupta <[email protected]> * Support cohort filtering of string target in rai_insights (#1771) * Port tests Signed-off-by: Gaurav Gupta <[email protected]> * Fix rai_insights Signed-off-by: Gaurav Gupta <[email protected]> Signed-off-by: Gaurav Gupta <[email protected]> * Simplify tests in test_cohort_filter.py (#1772) * Simply tests in test_cohort_filter.py Signed-off-by: Gaurav Gupta <[email protected]> * Change test name Signed-off-by: Gaurav Gupta <[email protected]> Signed-off-by: Gaurav Gupta <[email protected]> * Move cohort re-labelling logic to Cohort.ts (#1773) * Move cohort re-labelling logic to Cohort.ts Signed-off-by: Gaurav Gupta <[email protected]> * Lint fix Signed-off-by: Gaurav Gupta <[email protected]> * Lint fix Signed-off-by: Gaurav Gupta <[email protected]> Signed-off-by: Gaurav Gupta <[email protected]> * Update requirements.txt (#1779) * Refactor DataAnalysisTab into Chartview/DataAnalysisView and DataBalanceView (#1775) * Refactor DataAnalysisTab into Chartview/DataAnalysisView and DataBalanceView Signed-off-by: Gaurav Gupta <[email protected]> * Fix lint Signed-off-by: Gaurav Gupta <[email protected]> Signed-off-by: Gaurav Gupta <[email protected]> * [Highcharts] Enable csv download, xls download and view data table in highcharts (#1783) * enable csv xls download in hightcharts * localization * Add new data APIs for compute_matrix() and compute_error_tree() (#1790) Signed-off-by: Gaurav Gupta <[email protected]> Signed-off-by: Gaurav Gupta <[email protected]> * update e2e visit function (#1792) * Add rai_test_utils package (#1777) * Add rai_test_utils package Signed-off-by: Gaurav Gupta <[email protected]> * Lint fix and namespace changes Signed-off-by: Gaurav Gupta <[email protected]> * Fix duplicated cohorts not retaining the selection in combobox (#1785) * fix and e2e Signed-off-by: vinutha karanth <[email protected]> * update filter Signed-off-by: vinutha karanth <[email protected]> Signed-off-by: vinutha karanth <[email protected]> * release raiwidgets and responsibleai 0.23.0 (#1787) * fix release github action for raiwidgets and responsibleai by making it same as in gated build (#1788) * Add e2e for dependency plot Avg of abs value option (#1768) * fix dep plot Signed-off-by: vinutha karanth <[email protected]> * add e2e Signed-off-by: vinutha karanth <[email protected]> * lintfix Signed-off-by: vinutha karanth <[email protected]> * lintfix Signed-off-by: vinutha karanth <[email protected]> Signed-off-by: vinutha karanth <[email protected]> * update e2e visit function (#1792) * Fix code review comments Signed-off-by: Gaurav Gupta <[email protected]> Signed-off-by: Gaurav Gupta <[email protected]> Signed-off-by: vinutha karanth <[email protected]> Co-authored-by: Vinutha Karanth <[email protected]> Co-authored-by: Ilya Matiach <[email protected]> Co-authored-by: tongy-msft <[email protected]> * sort fix (#1798) Signed-off-by: vinutha karanth <[email protected]> Signed-off-by: vinutha karanth <[email protected]> * [LogarithmicScaling] Enable log scaling for data explorer, feature importance, counterfactual and casual (#1802) * update checkbox to toggle in axis config panel * support log toggle for counterfactual * enable log scaling for feature importance * enable log scaling for casual and data explorer * address comment * Update CODEOWNERS (#1805) * Fix ‘Close button’ and ‘Spin button’ present in new cohort dialog does not have any title or aria-label (#1806) * add aria label Signed-off-by: vinutha karanth <[email protected]> * address comment Signed-off-by: vinutha karanth <[email protected]> Signed-off-by: vinutha karanth <[email protected]> * Update erroranalysis tests to use new rai_test_utils package (#1800) * Update erroranalysis tests to use new rai_test_utils package Signed-off-by: Gaurav Gupta <[email protected]> * Remove shap and xgboost from test requirements Signed-off-by: Gaurav Gupta <[email protected]> * Pin rai_test_utils Signed-off-by: Gaurav Gupta <[email protected]> Signed-off-by: Gaurav Gupta <[email protected]> * Fix Heatmap tooltip theme (#1808) * fix tooltip color Signed-off-by: vinutha karanth <[email protected]> * fix theme Signed-off-by: vinutha karanth <[email protected]> * fix Signed-off-by: vinutha karanth <[email protected]> * rev Signed-off-by: vinutha karanth <[email protected]> Signed-off-by: vinutha karanth <[email protected]> * Calculate RAI insights for first 5K samples (#1803) Signed-off-by: Gaurav Gupta <[email protected]> Signed-off-by: Gaurav Gupta <[email protected]> * Add API for indicating large data scenario in ModelAssessmentContext (#1804) * [WIP] Add APIs for indicating large data scenario in ModelAssessmentContext Signed-off-by: Gaurav Gupta <[email protected]> * Change API name Signed-off-by: Gaurav Gupta <[email protected]> * Add unit test Signed-off-by: Gaurav Gupta <[email protected]> * Fix lint Signed-off-by: Gaurav Gupta <[email protected]> * Fix lint again Signed-off-by: Gaurav Gupta <[email protected]> Signed-off-by: Gaurav Gupta <[email protected]> * Add RAI version number to oss serialize result (#1812) * Add RAI version number to oss serialize result * update json file namg * add test * enable dropped_features for EA and explainer * enable EA and explainer for classification * remove unused comments * revert notebook change * revert notebook change * revert notebook change * revert causal cf changes * refactor getFeatureNamesAfterDrop to a common method * address comments on modelWrapper * update comments * update index.ts * remove unused variable * fix lint error * fix noneType error * address comments * fix a test error * support cf and causal * hide dropped_features for cf and causal * fix undefined feature_metadata error * fix undefined feature_metadata error * fix wrong cf predict value * fix undefined feature_metadata * fix undefined feature_metadata * address comments * address comments * fix feature_names test error * fix _feature_metadata undefined * fix failing test on undefined model Signed-off-by: Gaurav Gupta <[email protected]> Signed-off-by: vinutha karanth <[email protected]> Co-authored-by: Gaurav Gupta <[email protected]> Co-authored-by: Gaurav Gupta <[email protected]> Co-authored-by: Vinutha Karanth <[email protected]> Co-authored-by: Ilya Matiach <[email protected]>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: vinutha karanth [email protected]
Fix TypeError: Cannot read properties of undefined (reading 'sort')
Description
Checklist