Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add identity feature value to feature importance hover over #1637

Merged
merged 5 commits into from
Aug 15, 2022

Conversation

gaugup
Copy link
Contributor

@gaugup gaugup commented Aug 12, 2022

Description

Add identity feature value to feature importance hover over if the identity feature column is specified.

Checklist

Screenshot below:-

image

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

@codecov-commenter
Copy link

codecov-commenter commented Aug 12, 2022

Codecov Report

Merging #1637 (69f89e9) into main (e4f894b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1637   +/-   ##
=======================================
  Coverage   89.01%   89.01%           
=======================================
  Files         105      105           
  Lines        5489     5489           
=======================================
  Hits         4886     4886           
  Misses        603      603           
Flag Coverage Δ
unittests 89.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

gaugup added 2 commits August 15, 2022 10:08
Signed-off-by: Gaurav Gupta <[email protected]>
Signed-off-by: Gaurav Gupta <[email protected]>
@gaugup gaugup enabled auto-merge (squash) August 15, 2022 18:28
@gaugup gaugup merged commit d903c9e into main Aug 15, 2022
@gaugup gaugup deleted the gaugup/AddIdentityFeatureImp branch August 15, 2022 18:43
gaugup added a commit that referenced this pull request Aug 15, 2022
* Add identity feature value to feature importance hover over

Signed-off-by: Gaurav Gupta <[email protected]>

* Fix bug

Signed-off-by: Gaurav Gupta <[email protected]>

* Fix code review comments

Signed-off-by: Gaurav Gupta <[email protected]>

* Lint fix

Signed-off-by: Gaurav Gupta <[email protected]>

Signed-off-by: Gaurav Gupta <[email protected]>
gaugup added a commit that referenced this pull request Aug 16, 2022
* Add identity feature value to causal hover over

Signed-off-by: Gaurav Gupta <[email protected]>

* Fix lint errors

Signed-off-by: Gaurav Gupta <[email protected]>

* Minor refactoring in counterfactual package (#1634)

Signed-off-by: Gaurav Gupta <[email protected]>

Signed-off-by: Gaurav Gupta <[email protected]>

* Add identity feature value to feature importance hover over (#1637)

* Add identity feature value to feature importance hover over

Signed-off-by: Gaurav Gupta <[email protected]>

* Fix bug

Signed-off-by: Gaurav Gupta <[email protected]>

* Fix code review comments

Signed-off-by: Gaurav Gupta <[email protected]>

* Lint fix

Signed-off-by: Gaurav Gupta <[email protected]>

Signed-off-by: Gaurav Gupta <[email protected]>

* add UI tests for RAI text dashboard (#1636)

* Fix code review comments

Signed-off-by: Gaurav Gupta <[email protected]>

* lint fix

Signed-off-by: Gaurav Gupta <[email protected]>

Signed-off-by: Gaurav Gupta <[email protected]>
Co-authored-by: Ilya Matiach <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants