Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add identity feature value to causal hover over #1633

Merged
merged 9 commits into from
Aug 16, 2022
Merged

Add identity feature value to causal hover over #1633

merged 9 commits into from
Aug 16, 2022

Conversation

gaugup
Copy link
Contributor

@gaugup gaugup commented Aug 12, 2022

Description

Adding identity feature value to hover over in scatter plot in causal section.

Screenshot:-
image

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

@codecov-commenter
Copy link

codecov-commenter commented Aug 12, 2022 •
edited
Loading

Codecov Report

Merging #1633 (88829d8) into main (0a4c5dc) will decrease coverage by 3.42%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1633      +/-   ##
==========================================
- Coverage   89.01%   85.58%   -3.43%     
==========================================
  Files         105       58      -47     
  Lines        5489     2977    -2512     
==========================================
- Hits         4886     2548    -2338     
+ Misses        603      429     -174
Flag Coverage Δ
unittests 85.58% <ø> (-3.43%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
responsibleai/responsibleai/__version__.py
...ai/databalanceanalysis/feature_balance_measures.py
...onsibleai/responsibleai/serialization_utilities.py
...sponsibleai/responsibleai/managers/base_manager.py
responsibleai/responsibleai/_config/__init__.py
responsibleai/responsibleai/_tools/__init__.py
...bleai/responsibleai/_tools/causal/causal_config.py
...sibleai/responsibleai/_tools/shared/base_result.py
...ponsibleai/responsibleai/rai_insights/constants.py
responsibleai/responsibleai/_config/base_config.py
... and 37 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/gaugup/AddIDFeatureToCausal/dashboard/index.html

@gaugup
Fix lint errors
5b784d9 
Signed-off-by: Gaurav Gupta <[email protected]>
@github-actions
Copy link

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/gaugup/AddIDFeatureToCausal/dashboard/index.html

@github-actions
Copy link

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/gaugup/AddIDFeatureToCausal/dashboard/index.html

imatiach-msft
imatiach-msft approved these changes Aug 12, 2022
View reviewed changes
Copy link
Contributor

@imatiach-msft imatiach-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! added some minor comments

gaugup and others added 5 commits August 15, 2022 15:34
@gaugup
Minor refactoring in counterfactual package (#1634)
4b7586e 
Signed-off-by: Gaurav Gupta <[email protected]>

Signed-off-by: Gaurav Gupta <[email protected]>
@gaugup
Add identity feature value to feature importance hover over (#1637)
e2b29d3 
* Add identity feature value to feature importance hover over

Signed-off-by: Gaurav Gupta <[email protected]>

* Fix bug

Signed-off-by: Gaurav Gupta <[email protected]>

* Fix code review comments

Signed-off-by: Gaurav Gupta <[email protected]>

* Lint fix

Signed-off-by: Gaurav Gupta <[email protected]>

Signed-off-by: Gaurav Gupta <[email protected]>
@imatiach-msft @gaugup
add UI tests for RAI text dashboard (#1636)
cd9514a
@gaugup
Fix code review comments
758ca30 
Signed-off-by: Gaurav Gupta <[email protected]>
@gaugup
Merge branch 'main' into gaugup/AddIDFeatureToCausal
6f1fd04
@github-actions
Copy link

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/gaugup/AddIDFeatureToCausal/dashboard/index.html

@gaugup
lint fix
88829d8 
Signed-off-by: Gaurav Gupta <[email protected]>
@github-actions
Copy link

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/gaugup/AddIDFeatureToCausal/dashboard/index.html

1 similar comment
@github-actions
Copy link

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/gaugup/AddIDFeatureToCausal/dashboard/index.html

@gaugup gaugup enabled auto-merge (squash) August 16, 2022 01:00
@gaugup gaugup merged commit 8484fc1 into main Aug 16, 2022
@gaugup gaugup deleted the gaugup/AddIDFeatureToCausal branch August 16, 2022 02:41
@imatiach-msft imatiach-msft mentioned this pull request Aug 19, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imatiach-msft imatiach-msft imatiach-msft approved these changes

@vinuthakaranth vinuthakaranth vinuthakaranth approved these changes

@RubyZ10 RubyZ10 RubyZ10 approved these changes

@tongyu-microsoft tongyu-microsoft tongyu-microsoft approved these changes

@romanlutz romanlutz Awaiting requested review from romanlutz

@xuke444 xuke444 Awaiting requested review from xuke444 xuke444 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@gaugup @codecov-commenter @imatiach-msft @vinuthakaranth @RubyZ10 @tongyu-microsoft