add UI tests for RAI text dashboard #1636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imatiach-msft
requested review from
gaugup,
tongyu-microsoft,
xuke444,
RubyZ10,
vinuthakaranth and
romanlutz
as code owners
imatiach-msft
force-pushed
the
ilmat/text-ui-tests
branch
from
4432189 to
908a3a1
Compare
Codecov Report
@@ Coverage Diff @@
## main #1636 +/- ##
=======================================
Coverage 89.01% 89.01%
=======================================
Files 105 105
Lines 5489 5489
=======================================
Hits 4886 4886
Misses 603 603
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
imatiach-msft
force-pushed
the
ilmat/text-ui-tests
branch
from
908a3a1 to
128d92d
Compare
imatiach-msft
commented
Aug 12, 2022
1 similar comment
RubyZ10
approved these changes
Aug 15, 2022
gaugup
pushed a commit
that referenced
this pull request
Aug 15, 2022
gaugup
added a commit
that referenced
this pull request
Aug 16, 2022
* Add identity feature value to causal hover over Signed-off-by: Gaurav Gupta <[email protected]> * Fix lint errors Signed-off-by: Gaurav Gupta <[email protected]> * Minor refactoring in counterfactual package (#1634) Signed-off-by: Gaurav Gupta <[email protected]> Signed-off-by: Gaurav Gupta <[email protected]> * Add identity feature value to feature importance hover over (#1637) * Add identity feature value to feature importance hover over Signed-off-by: Gaurav Gupta <[email protected]> * Fix bug Signed-off-by: Gaurav Gupta <[email protected]> * Fix code review comments Signed-off-by: Gaurav Gupta <[email protected]> * Lint fix Signed-off-by: Gaurav Gupta <[email protected]> Signed-off-by: Gaurav Gupta <[email protected]> * add UI tests for RAI text dashboard (#1636) * Fix code review comments Signed-off-by: Gaurav Gupta <[email protected]> * lint fix Signed-off-by: Gaurav Gupta <[email protected]> Signed-off-by: Gaurav Gupta <[email protected]> Co-authored-by: Ilya Matiach <[email protected]>
This was referenced Aug 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add UI tests for the new RAI text dashboard, specifically the individual feature importances for text component.
This includes testing the:
1.) TextHighlighting component, which displays the text passage
2.) The TextFeatureLegend
3.) The local importance values as a bar chart
More testing could be done in the future for:
1.) Slider, to select different number of words to view in the bar chart
2.) Class importance weights dropdown
3.) Radio button to select all features, positive features or negative features
Resolves issue: #1549
Checklist