Skip to content

Conversation

@agg23
Copy link
Contributor

@agg23 agg23 commented Mar 26, 2025

Expanding support for warning annotations introduced in #34861.

Automatically insert location field into non-user pushed annotations for use in reporters. Additionally normalized TestAnnotation type across the project.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

Test results for "tests 1"

35 failed
❌ [playwright-test] › tests/access-data.spec.ts:41:5 › should access annotations in fixture @macos-latest-node18-1
❌ [playwright-test] › tests/reporter.spec.ts:579:5 › should report annotations from test declaration @macos-latest-node18-1
❌ [playwright-test] › tests/test-modifiers.spec.ts:19:5 › test modifiers should work @macos-latest-node18-1
❌ [playwright-test] › tests/test-modifiers.spec.ts:393:5 › should skip inside fixture @macos-latest-node18-1
❌ [playwright-test] › tests/test-modifiers.spec.ts:426:5 › test.skip with worker fixtures only should skip before hooks and tests @macos-latest-node18-1
❌ [playwright-test] › tests/test-modifiers.spec.ts:568:5 › should skip all tests from beforeAll @macos-latest-node18-1
❌ [playwright-test] › tests/test-modifiers.spec.ts:676:5 › static modifiers should be added in serial mode @macos-latest-node18-1
❌ [playwright-test] › tests/access-data.spec.ts:41:5 › should access annotations in fixture @ubuntu-latest-node18-1
❌ [playwright-test] › tests/reporter.spec.ts:579:5 › should report annotations from test declaration @ubuntu-latest-node18-1
❌ [playwright-test] › tests/test-modifiers.spec.ts:19:5 › test modifiers should work @ubuntu-latest-node18-1
❌ [playwright-test] › tests/test-modifiers.spec.ts:393:5 › should skip inside fixture @ubuntu-latest-node18-1
❌ [playwright-test] › tests/test-modifiers.spec.ts:426:5 › test.skip with worker fixtures only should skip before hooks and tests @ubuntu-latest-node18-1
❌ [playwright-test] › tests/test-modifiers.spec.ts:568:5 › should skip all tests from beforeAll @ubuntu-latest-node18-1
❌ [playwright-test] › tests/test-modifiers.spec.ts:676:5 › static modifiers should be added in serial mode @ubuntu-latest-node18-1
❌ [playwright-test] › tests/access-data.spec.ts:41:5 › should access annotations in fixture @ubuntu-latest-node20-1
❌ [playwright-test] › tests/reporter.spec.ts:579:5 › should report annotations from test declaration @ubuntu-latest-node20-1
❌ [playwright-test] › tests/test-modifiers.spec.ts:19:5 › test modifiers should work @ubuntu-latest-node20-1
❌ [playwright-test] › tests/test-modifiers.spec.ts:393:5 › should skip inside fixture @ubuntu-latest-node20-1
❌ [playwright-test] › tests/test-modifiers.spec.ts:426:5 › test.skip with worker fixtures only should skip before hooks and tests @ubuntu-latest-node20-1
❌ [playwright-test] › tests/test-modifiers.spec.ts:568:5 › should skip all tests from beforeAll @ubuntu-latest-node20-1
❌ [playwright-test] › tests/test-modifiers.spec.ts:676:5 › static modifiers should be added in serial mode @ubuntu-latest-node20-1
❌ [playwright-test] › tests/access-data.spec.ts:41:5 › should access annotations in fixture @ubuntu-latest-node22-1
❌ [playwright-test] › tests/reporter.spec.ts:579:5 › should report annotations from test declaration @ubuntu-latest-node22-1
❌ [playwright-test] › tests/test-modifiers.spec.ts:19:5 › test modifiers should work @ubuntu-latest-node22-1
❌ [playwright-test] › tests/test-modifiers.spec.ts:393:5 › should skip inside fixture @ubuntu-latest-node22-1
❌ [playwright-test] › tests/test-modifiers.spec.ts:426:5 › test.skip with worker fixtures only should skip before hooks and tests @ubuntu-latest-node22-1
❌ [playwright-test] › tests/test-modifiers.spec.ts:568:5 › should skip all tests from beforeAll @ubuntu-latest-node22-1
❌ [playwright-test] › tests/test-modifiers.spec.ts:676:5 › static modifiers should be added in serial mode @ubuntu-latest-node22-1
❌ [playwright-test] › tests/access-data.spec.ts:41:5 › should access annotations in fixture @windows-latest-node18-1
❌ [playwright-test] › tests/reporter.spec.ts:579:5 › should report annotations from test declaration @windows-latest-node18-1
❌ [playwright-test] › tests/test-modifiers.spec.ts:19:5 › test modifiers should work @windows-latest-node18-1
❌ [playwright-test] › tests/test-modifiers.spec.ts:393:5 › should skip inside fixture @windows-latest-node18-1
❌ [playwright-test] › tests/test-modifiers.spec.ts:426:5 › test.skip with worker fixtures only should skip before hooks and tests @windows-latest-node18-1
❌ [playwright-test] › tests/test-modifiers.spec.ts:568:5 › should skip all tests from beforeAll @windows-latest-node18-1
❌ [playwright-test] › tests/test-modifiers.spec.ts:676:5 › static modifiers should be added in serial mode @windows-latest-node18-1

2 flaky ⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-screenshot.spec.ts:345:5 › page screenshot › should work while navigating @webkit-ubuntu-22.04-node18

38902 passed, 805 skipped
✔️✔️✔️

Merge workflow run.

@github-actions

This comment has been minimized.

dgozman
dgozman previously approved these changes Mar 31, 2025
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 1, 2025

Test results for "tests 1"

2 flaky ⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/browsercontext-viewport-mobile.spec.ts:206:5 › mobile viewport › view scale should reset after navigation @webkit-ubuntu-22.04-node18

39017 passed, 805 skipped
✔️✔️✔️

Merge workflow run.

dgozman
dgozman previously approved these changes Apr 2, 2025
@agg23 agg23 merged commit 92c5d65 into microsoft:main Apr 2, 2025
28 of 29 checks passed
agg23 added a commit to agg23/playwright that referenced this pull request Apr 15, 2025
dgozman pushed a commit that referenced this pull request Apr 16, 2025
aslushnikov added a commit to aslushnikov/playwright that referenced this pull request Jul 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants