Revert "chore: add location named property to annotations (#35373)" #35620
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Test results for "tests 1"5621 passed, 29 skipped Merge workflow run. |
dgozman
approved these changes
Apr 15, 2025
| if (typeof modifierArgs[0] === 'function') | ||
| throw new Error(`test.${type}() with a function can only be called inside describe block`); | ||
| testInfo._modifier(type, location, modifierArgs as [any, any]); | ||
| testInfo[type](...modifierArgs as [any, any]); |
Contributor
There was a problem hiding this comment.
To be honest, I liked the testInfo._modifier because it's proper, but oh well 😄
Contributor
Test results for "tests 1"3 flaky39029 passed, 921 skipped Merge workflow run. |
agg23
added a commit
to agg23/playwright
that referenced
this pull request
Apr 15, 2025
agg23
added a commit
to agg23/playwright
that referenced
this pull request
Apr 15, 2025
dgozman
pushed a commit
that referenced
this pull request
Apr 16, 2025
agg23
added a commit
that referenced
this pull request
Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 92c5d65.