Skip to content

Conversation

@agg23
Copy link
Contributor

@agg23 agg23 commented Feb 19, 2025

Continuation of #34845. Specifically detect floating promises in hooks, and log them accordingly. The warning annotations are associated with the test that instigated the running of that hook.

Screenshot 2025-02-19 at 12 48 43 PM

@agg23 agg23 requested a review from pavelfeldman February 19, 2025 20:55
@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

Test results for "tests 1"

6 flaky ⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [installation tests] › tests/playwright-electron-should-work.spec.ts:31:5 › electron should work with special characters in path @package-installations-macos-latest
⚠️ [webkit-library] › tests/library/browsercontext-clearcookies.spec.ts:52:3 › should remove cookies by name @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/proxy.spec.ts:93:11 › should proxy local network requests › by default › link-local @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-filechooser.spec.ts:24:5 › should upload multiple large files @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-set-input-files.spec.ts:204:5 › should upload large file with relative path @webkit-ubuntu-22.04-node18

38672 passed, 794 skipped
✔️✔️✔️

Merge workflow run.

@agg23 agg23 merged commit 33c0a1b into microsoft:main Feb 20, 2025
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants