Skip to content

Add GetVendorId for MiGraphX factory #25515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wonchung-microsoft wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add GetVendorId for MiGraphX factory #25515

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions onnxruntime/core/providers/migraphx/migraphx_provider_factory.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,7 @@ struct MigraphXEpFactory : OrtEpFactory {
: ort_api{ort_api_in}, ep_name{ep_name}, ort_hw_device_type{hw_type}, default_logger{default_logger_in} {
GetName = GetNameImpl;
GetVendor = GetVendorImpl;
GetVendorId = GetVendorIdImpl;
Copy link
Contributor

@nieubank nieubank Jul 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also include the stubs that Scott is adding in #25503

Copy link
Contributor Author

@wonchung-microsoft wonchung-microsoft Jul 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@psakhamoori Would you please drive this comment and the pr merge?

Copy link
Contributor

@psakhamoori psakhamoori Jul 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wonchung-microsoft Please help add description to this PR

GetSupportedDevices = GetSupportedDevicesImpl;
CreateEp = CreateEpImpl;
ReleaseEp = ReleaseEpImpl;
Expand All @@ -201,6 +202,11 @@ struct MigraphXEpFactory : OrtEpFactory {
return factory->vendor.c_str();
}

static uint32_t GetVendorIdImpl(const OrtEpFactory* this_ptr) {
const auto* factory = static_cast<const MigraphXEpFactory*>(this_ptr);
return factory->vendor_id;
}

// Creates and returns OrtEpDevice instances for all OrtHardwareDevices that this factory supports.
// An EP created with this factory is expected to be able to execute a model with *all* supported
// hardware devices at once. A single instance of MigraphX EP is not currently setup to partition a model among
Expand Down
Loading