Add GetVendorId for MiGraphX factory #25515
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nieubank
reviewed
Jul 23, 2025
| : ort_api{ort_api_in}, ep_name{ep_name}, ort_hw_device_type{hw_type}, default_logger{default_logger_in} { | ||
| GetName = GetNameImpl; | ||
| GetVendor = GetVendorImpl; | ||
| GetVendorId = GetVendorIdImpl; |
Contributor
There was a problem hiding this comment.
We should also include the stubs that Scott is adding in #25503
Contributor
Author
There was a problem hiding this comment.
@psakhamoori Would you please drive this comment and the pr merge?
Contributor
There was a problem hiding this comment.
@wonchung-microsoft Please help add description to this PR
Contributor
jywu-msft
added
the
ep:MIGraphX
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.