-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Update OrtEpFactory in new EPs #25503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update OrtEpFactory in new EPs #25503
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the OrtEpFactory implementations in new execution providers (VitisAI, OpenVINO, and NvTensorRtRtx) to add stub implementations for allocator, data transfer, and stream-related functionality.
- Adds stub implementations for CreateAllocator/ReleaseAllocator functions that return appropriate error statuses
- Implements CreateDataTransfer stubs that return nullptr to indicate no support
- Adds IsStreamAware and CreateSyncStreamForDevice implementations that indicate no stream support
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| vitisai_provider_factory.cc | Adds allocator, data transfer, and stream stub implementations to VitisAIEpFactory |
| ov_factory.h | Adds stub method implementations and reorganizes GetVersionImpl for OpenVINOEpPluginFactory |
| ov_factory.cc | Updates constructor to assign the new stub function pointers |
| nv_provider_factory.cc | Adds allocator, data transfer, and stream stub implementations to NvTensorRtRtxEpFactory |
Comments suppressed due to low confidence (1)
onnxruntime/core/providers/openvino/ov_factory.h:160
- Parameter name 'this' is inconsistent with other functions that use 'this_ptr'. Should be renamed to 'this_ptr' for consistency.
static void ORT_API_CALL ReleaseAllocatorImpl(OrtEpFactory* this, OrtAllocator* allocator) noexcept {
onnxruntime/core/providers/nv_tensorrt_rtx/nv_provider_factory.cc
Outdated
Show resolved
Hide resolved
|
build errors /onnxruntime_src/onnxruntime/core/providers/openvino/ov_factory.h: In static member function ‘static bool onnxruntime::openvino_ep::OpenVINOEpPluginFactory::IsStreamAwareImpl(const OrtEpFactory*)’: |
|
Hi there! We haven't cut the release branch for this version yet, so I'm removing the |
### Description <!-- Describe your changes. --> Update OrtEpFactory in new EPs to add allocator, data transfer and stream stubs. ### Motivation and Context <!-- - Why is this change required? What problem does it solve? - If it fixes an open issue, please link to the issue here. -->
Description
Update OrtEpFactory in new EPs to add allocator, data transfer and stream stubs.
Motivation and Context