Correctly iterate over the providers to check if graph capture is enabled - #1497
Merged
Merged
Conversation
Baiju Meswani (baijumeswani)
requested review from
aciddelgado and
kunal-vaishnavi
May 20, 2025 16:36
kunal-vaishnavi
previously approved these changes
May 20, 2025
Baiju Meswani (baijumeswani)
dismissed
kunal-vaishnavi’s stale review
via
May 20, 2025 18:34
49da4ca
Baiju Meswani (baijumeswani)
enabled auto-merge (squash)
May 20, 2025 21:23
kunal-vaishnavi
approved these changes
May 20, 2025
This was referenced May 21, 2025
Baiju Meswani (baijumeswani)
added a commit
that referenced
this pull request
May 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #1454 providers are selected based on Config.SessionOptions.providers, and not on the Config.SessionOptions.provider_options.
When deciding to enable graph capture, the code now iterates over the providers instead of provider options.