Persist provider options across ClearProviders, AppendProvider where possible - #1454
Merged
Baiju Meswani (baijumeswani) merged 3 commits intoMay 7, 2025
Merged
Conversation
Nenad Banfic (nenad1002)
previously approved these changes
May 6, 2025
Baiju Meswani (baijumeswani)
enabled auto-merge (squash)
May 6, 2025 20:48
Ryan Hill (RyanUnderhill)
approved these changes
May 7, 2025
Ryan Hill (RyanUnderhill)
pushed a commit
that referenced
this pull request
May 12, 2025
Merged
Baiju Meswani (baijumeswani)
added a commit
that referenced
this pull request
May 14, 2025
Address previous PR review comments from #1470 (#1473) Address QNN specific regressions (#1470) Fix array eos_token_id handling (#1463) Constrained decoding integration (#1381) Remove BF16 CPU from valid GQA configuration (#1469) Avoid adding providers if not requested (#1464) Persist provider options across ClearProviders, AppendProvider where possible (#1454) Fix accuracy issues with Gemma models (#1448) Add bfloat16 support in model builder (#1447) Add final norm for LoRA models (#1446) Update version to 0.8.0-rc3 --------- Co-authored-by: kunal-vaishnavi <115581922+kunal-vaishnavi@users.noreply.github.com> Co-authored-by: Nenad Banfic <46795300+nenad1002@users.noreply.github.com> Co-authored-by: Nenad Banfic <nebanfic@microsoft.com> Co-authored-by: Baiju Meswani <bmeswani@microsoft.com> Co-authored-by: Abhishek Jindal <abjindal@microsoft.com> Co-authored-by: Ying Xiong <yingxiong@microsoft.com> Co-authored-by: Michał Moskal <michal@moskal.me> Co-authored-by: Kunal Vaishnavi <kvaishnavi@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, most applications will ClearProviders and AppendProvider to change the execution provider at runtime to the desired EP. While doing this, the provider options listed in the genai config.json are lost.
Some models require a specific provider option to run correctly. So, doing
ClearProvidersand then doingAppendProviderdoes not work since the options are lost in the process.This pull-request introduces changes that will clear the providers instead of the provider options in the config. At runtime, the providers array is used to determine which provider to pick.