Skip to content

NvTensorRtRtx EP option in GenAI - model builder - #1453

Merged
Baiju Meswani (baijumeswani) merged 20 commits into
microsoft:mainfrom
BLSharda:bhaviksharda/modelbuilder_ep_NvTensorRtRtx
May 28, 2025
Merged

NvTensorRtRtx EP option in GenAI - model builder#1453
Baiju Meswani (baijumeswani) merged 20 commits into
microsoft:mainfrom
BLSharda:bhaviksharda/modelbuilder_ep_NvTensorRtRtx

Conversation

@BLSharda

Copy link
Copy Markdown
Contributor

Add NvTensorRtRtx EP option in GenAI - model builder

  • NvTensorRtRtx uses opset 21.
  • Enables use_qdq and uses Gelu standard op from opset 20.

…ensorRtRtx EP.

- NvTensorRtRtx uses opset 21.
- Enables use_qdq and uses Gelu standard op from opset 20.
@BLSharda
Bhavik Sharda (BLSharda) marked this pull request as ready for review May 6, 2025 14:39
@BLSharda Bhavik Sharda (BLSharda) changed the title Adding option in Model builder to produce opset 21 ONNX model for NvT… NvTensorRtRtx EP option in GenAI - model builder May 6, 2025
Enabling Contrib-Ops Expansion

Tested with Gemma-2b-it, Gemma-2-2b-it, deepseek llama and Nemotron 4b.
Comment thread src/python/py/models/builder.py
Comment thread src/python/py/models/builder.py Outdated
Comment thread src/python/py/models/builder.py Outdated
Comment thread src/python/py/models/builder.py Outdated
Comment thread src/python/py/models/builder.py
Comment thread src/python/py/models/builder.py Outdated
Comment thread src/python/py/models/builder.py
Comment thread src/python/py/models/builder.py Outdated
Comment thread src/python/py/models/builder.py
Comment thread src/python/py/models/builder.py
Bhavik Sharda (BLSharda) and others added 6 commits May 9, 2025 13:28
Co-authored-by: kunal-vaishnavi <115581922+kunal-vaishnavi@users.noreply.github.com>
Co-authored-by: kunal-vaishnavi <115581922+kunal-vaishnavi@users.noreply.github.com>
Co-authored-by: kunal-vaishnavi <115581922+kunal-vaishnavi@users.noreply.github.com>
Updating functions as hidden starts with _*

Co-authored-by: kunal-vaishnavi <115581922+kunal-vaishnavi@users.noreply.github.com>
Implemented separate _make_layernormalization for contirb-ops
Review comment fixed for Gelu parent function which decides between official and contrib-ops as well.
Comment thread src/python/py/models/builder.py Outdated
Comment thread src/python/py/models/builder.py Outdated
Comment thread src/python/py/models/builder.py Outdated
Comment thread src/python/py/models/builder.py Outdated
Comment thread src/python/py/models/builder.py Outdated
Bhavik Sharda (BLSharda) and others added 4 commits May 14, 2025 13:51
Co-authored-by: kunal-vaishnavi <115581922+kunal-vaishnavi@users.noreply.github.com>
Reverting unwanted changes
@BLSharda

Copy link
Copy Markdown
Contributor Author

kunal-vaishnavi, can you help retrigger pipeline? seems like "CUDNN" error not related to my change.

@anskumar01

Copy link
Copy Markdown

kunal-vaishnavi , can you please help retrigger the pipeline and help merge this change once review is final?

@BLSharda

Copy link
Copy Markdown
Contributor Author

kunal-vaishnavi , can you help merge this PR?

@BLSharda

Copy link
Copy Markdown
Contributor Author

Need help merge this PR as this is already reviewed & approved.

Also, the pipeline failure Linux CUDA x64 Build / linux-cuda-x64-build is unrelated to code changes in this PR.

+ az login --identity --username 63b63039-6328-442f-954b-5a64d124e5b4
ERROR: Passing the managed identity ID with --username is no longer supported. 

@BLSharda

Copy link
Copy Markdown
Contributor Author

Need help merge this PR as this is already reviewed & approved.

Also, the pipeline failure Linux CUDA x64 Build / linux-cuda-x64-build is unrelated to code changes in this PR.

+ az login --identity --username 63b63039-6328-442f-954b-5a64d124e5b4
ERROR: Passing the managed identity ID with --username is no longer supported. 

kunal-vaishnavi and Baiju Meswani (@baijumeswani) , can you help merge this change?

@baijumeswani

Copy link
Copy Markdown
Collaborator

The issue was addressed in #1497. Please merge main and push.

@BLSharda

Bhavik Sharda (BLSharda) commented May 28, 2025

Copy link
Copy Markdown
Contributor Author

The issue was addressed in #1497. Please merge main and push.

Baiju Meswani (@baijumeswani), sure, after merge and push still hitting issue with same test "Linux CUDA x64 Build / linux-cuda-x64-build". And as this PR doesn't affect CUDA model builder, this is unrelated, right?

[E:onnxruntime:, cuda_call.cc:123 CudaCall] CUDA failure 700: an illegal memory access was encountered ; GPU=0 ; hostname=27d6b4d1345e ; file=/onnxruntime_src/onnxruntime/core/providers/cuda/gpu_data_transfer.cc ; line=73 ; expr=cudaMemcpyAsync(dst_data, src_data, bytes, cudaMemcpyDeviceToHost, static_cast<cudaStream_t>(stream.GetHandle()));

Thanks, I see pipeline is passing now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0.8.1 Patch Release for 0.8.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants