Avoid adding providers if not requested - #1464
Merged
Merged
Conversation
Contributor
|
So the issue is that the OnComplete() was adding all providers back to the list from the provider options. The fix is to do it higher up to avoid SetProviderOption from doing it again? |
Collaborator
Author
|
Yes, exactly. :) |
Contributor
|
Hmm, I think moving it up just moves the problem a little and would still be a surprise if we allow dynamic session options. If you move it into the Config constructor it'll happen once at load time. |
Ryan Hill (RyanUnderhill)
approved these changes
May 8, 2025
Collaborator
Author
|
Thanks for the review. :) |
Ryan Hill (RyanUnderhill)
pushed a commit
that referenced
this pull request
May 12, 2025
Merged
Baiju Meswani (baijumeswani)
added a commit
that referenced
this pull request
May 14, 2025
Address previous PR review comments from #1470 (#1473) Address QNN specific regressions (#1470) Fix array eos_token_id handling (#1463) Constrained decoding integration (#1381) Remove BF16 CPU from valid GQA configuration (#1469) Avoid adding providers if not requested (#1464) Persist provider options across ClearProviders, AppendProvider where possible (#1454) Fix accuracy issues with Gemma models (#1448) Add bfloat16 support in model builder (#1447) Add final norm for LoRA models (#1446) Update version to 0.8.0-rc3 --------- Co-authored-by: kunal-vaishnavi <115581922+kunal-vaishnavi@users.noreply.github.com> Co-authored-by: Nenad Banfic <46795300+nenad1002@users.noreply.github.com> Co-authored-by: Nenad Banfic <nebanfic@microsoft.com> Co-authored-by: Baiju Meswani <bmeswani@microsoft.com> Co-authored-by: Abhishek Jindal <abjindal@microsoft.com> Co-authored-by: Ying Xiong <yingxiong@microsoft.com> Co-authored-by: Michał Moskal <michal@moskal.me> Co-authored-by: Kunal Vaishnavi <kvaishnavi@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a previous PR: #1454 I added support for the providers to persist the provider options across clearprovider->appendprovider. A bug was introduced where the providers always got built to include every provider in the provider options.
This PR fixes it. So, if the user clears the providers , and then appends a provider, only the new provider should be present in the providers list (not all the ones in the provider options).